[CodeQuality] Skip Common Entity contains subnamespaces on ControllerMethodInjectionToConstructorRector (#878)

* [CodeQuality] Skip Common Entity contains subnamespaces on ControllerMethodInjectionToConstructorRector

* [CodeQuality] Skip Common Entity contains subnamespaces on ControllerMethodInjectionToConstructorRector

* [CodeQuality] Skip Common Entity contains subnamespaces on ControllerMethodInjectionToConstructorRector

Author: samsonasik

rules-tests/CodeQuality/Rector/Class_/ControllerMethodInjectionToConstructorRector/Fixture/skip_namespaced_document_or_entity.php.inc

@@ -0,0 +1,26 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Tests\CodeQuality\Rector\Class_\ControllerMethodInjectionToConstructorRector\Fixture;
+
+use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+use Symfony\Component\HttpFoundation\Request;
+
+/**
+ * Entity or Document can be detected via ValueResolver that query in ValueResolver services
+ */
+final class SkipNamespacedDocumentOrEntity extends AbstractController
+{
+    public function someAction(Request $request, \App\Entity\SomeEntity $entity)
+    {
+    }
+
+    public function some2Action(Request $request, \App\Document\SomeEntity $document)
+    {
+    }
+
+    public function some3Action(Request $request, \App\Model\SomeEntity $document)
+    {
+    }
+}

rules/CodeQuality/Rector/Class_/ControllerMethodInjectionToConstructorRector.php

@@ -31,6 +31,11 @@
  */
 final class ControllerMethodInjectionToConstructorRector extends AbstractRector
 {
+    /**
+     * @var string[]
+     */
+    private const COMMON_ENTITY_CONTAINS_SUBNAMESPACES = ['\\Entity', '\\Document', '\\Model'];
+
     public function __construct(
         private readonly ControllerAnalyzer $controllerAnalyzer,
         private readonly ControllerMethodAnalyzer $controllerMethodAnalyzer,
@@ -130,6 +135,12 @@ public function refactor(Node $node): ?Node
                     continue;
                 }
 
+                foreach (self::COMMON_ENTITY_CONTAINS_SUBNAMESPACES as $commonEntityContainsNamespace) {
+                    if (str_contains($this->getName($param->type), $commonEntityContainsNamespace)) {
+                        continue 2;
+                    }
+                }
+
                 // @todo allow parameter converter
                 unset($classMethod->params[$key]);