Skip to content

feat: add flysystem key #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 2 commits into from
Mar 11, 2025
Merged

feat: add flysystem key #705

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ce96bc
feat: add flysystem key
Mar 8, 2025
4148bb7
docs: add link for reference
Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions rules/CodeQuality/Rector/Closure/StringExtensionToConfigBuilderRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ final class StringExtensionToConfigBuilderRector extends AbstractRector
'maker' => 'Symfony\Config\MakerConfig',
'nelmio_cors' => 'Symfony\Config\NelmioCorsConfig',
'api_platform' => 'Symfony\Config\ApiPlatformConfig',
'flysystem' => 'Symfony\Config\FlysystemConfig',
Copy link
Copy Markdown
Member

@samsonasik samsonasik Mar 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add @see link comment reference on it for future reference? Thank you.

Copy link
Copy Markdown
Author

@dsdeboer dsdeboer Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ofcourse! Could you tell me where you want the link to point to?

Copy link
Copy Markdown
Member

@samsonasik samsonasik Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just in above it, like:

       // @see ...
        'flysystem' => 'Symfony\Config\FlysystemConfig'

Copy link
Copy Markdown
Author

@dsdeboer dsdeboer Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, 4148bb7 is what you meant.

Copy link
Copy Markdown
Member

@samsonasik samsonasik Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure I understand how the class work, is Symfony\Config\FlysystemConfig auto created on the fly? since your reference pointed to different class

Copy link
Copy Markdown
Author

@dsdeboer dsdeboer Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's correct. If you installed flysystem then the added class is automatically generated based on the reference. This works the same as currently for the other keys.

];

public function __construct(
Expand Down