Skip to content

[7.3] Update InvokableCommandRector to InvokableCommandInputAttributeRector to improve discoverability #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
May 5, 2025
Merged

[7.3] Update InvokableCommandRector to InvokableCommandInputAttributeRector to improve discoverability #743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion config/sets/symfony/symfony5/symfony53.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
declare(strict_types=1);

use Rector\Config\RectorConfig;
use Rector\Symfony\Symfony53\Rector\StaticPropertyFetch\KernelTestCaseContainerPropertyDeprecationRector;

# https://github.com/symfony/symfony/blob/5.4/UPGRADE-5.3.md

Expand Down
4 changes: 2 additions & 2 deletions config/sets/symfony/symfony73.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@

use Rector\Config\RectorConfig;
use Rector\Symfony\Symfony73\Rector\Class_\CommandHelpToAttributeRector;
use Rector\Symfony\Symfony73\Rector\Class_\InvokableCommandRector;
use Rector\Symfony\Symfony73\Rector\Class_\InvokableCommandInputAttributeRector;

// @see https://github.com/symfony/symfony/blame/7.3/UPGRADE-7.3.md

return RectorConfig::configure()
->withRules([CommandHelpToAttributeRector::class, InvokableCommandRector::class]);
->withRules([CommandHelpToAttributeRector::class, InvokableCommandInputAttributeRector::class]);
2 changes: 1 addition & 1 deletion ...ector/Class_/CommandHelpToAttributeRector/Fixture/skip_has_help_attribute_command.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

namespace Rector\Symfony\Tests\Symfony73\Rector\Class_\InvokableCommandRector\Fixture;
namespace Rector\Symfony\Tests\Symfony73\Rector\Class_\InvokableCommandInputAttributeRector\Fixture;

use Symfony\Component\Console\Attribute\AsCommand;
use Symfony\Component\Console\Command\Command;
Expand Down
4 changes: 2 additions & 2 deletions ...ommandRector/Fixture/some_command.php.inc → ...ributeRector/Fixture/some_command.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

namespace Rector\Symfony\Tests\Symfony73\Rector\Class_\InvokableCommandRector\Fixture;
namespace Rector\Symfony\Tests\Symfony73\Rector\Class_\InvokableCommandInputAttributeRector\Fixture;

use Symfony\Component\Console\Attribute\AsCommand;
use Symfony\Component\Console\Command\Command;
Expand Down Expand Up @@ -33,7 +33,7 @@ final class SomeCommand extends Command
-----
<?php

namespace Rector\Symfony\Tests\Symfony73\Rector\Class_\InvokableCommandRector\Fixture;
namespace Rector\Symfony\Tests\Symfony73\Rector\Class_\InvokableCommandInputAttributeRector\Fixture;

use Symfony\Component\Console\Attribute\AsCommand;
use Symfony\Component\Console\Command\Command;
Expand Down
4 changes: 2 additions & 2 deletions ...some_command_with_method_chaining.php.inc → ...some_command_with_method_chaining.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

namespace Rector\Symfony\Tests\Symfony73\Rector\Class_\InvokableCommandRector\Fixture;
namespace Rector\Symfony\Tests\Symfony73\Rector\Class_\InvokableCommandInputAttributeRector\Fixture;

use Symfony\Component\Console\Attribute\AsCommand;
use Symfony\Component\Console\Command\Command;
Expand Down Expand Up @@ -34,7 +34,7 @@ final class SomeCommandWithMethodChaining extends Command
-----
<?php

namespace Rector\Symfony\Tests\Symfony73\Rector\Class_\InvokableCommandRector\Fixture;
namespace Rector\Symfony\Tests\Symfony73\Rector\Class_\InvokableCommandInputAttributeRector\Fixture;

use Symfony\Component\Console\Attribute\AsCommand;
use Symfony\Component\Console\Command\Command;
Expand Down
4 changes: 2 additions & 2 deletions ...ixture/some_command_with_set_help.php.inc → ...ixture/some_command_with_set_help.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

namespace Rector\Symfony\Tests\Symfony73\Rector\Class_\InvokableCommandRector\Fixture;
namespace Rector\Symfony\Tests\Symfony73\Rector\Class_\InvokableCommandInputAttributeRector\Fixture;

use Symfony\Component\Console\Attribute\AsCommand;
use Symfony\Component\Console\Command\Command;
Expand Down Expand Up @@ -34,7 +34,7 @@ final class SomeCommandWithSetHelp extends Command
-----
<?php

namespace Rector\Symfony\Tests\Symfony73\Rector\Class_\InvokableCommandRector\Fixture;
namespace Rector\Symfony\Tests\Symfony73\Rector\Class_\InvokableCommandInputAttributeRector\Fixture;

use Symfony\Component\Console\Attribute\AsCommand;
use Symfony\Component\Console\Command\Command;
Expand Down
4 changes: 2 additions & 2 deletions ...mandRector/InvokableCommandRectorTest.php → ...okableCommandInputAttributeRectorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@

declare(strict_types=1);

namespace Rector\Symfony\Tests\Symfony73\Rector\Class_\InvokableCommandRector;
namespace Rector\Symfony\Tests\Symfony73\Rector\Class_\InvokableCommandInputAttributeRector;

use Iterator;
use PHPUnit\Framework\Attributes\DataProvider;
use Rector\Testing\PHPUnit\AbstractRectorTestCase;

final class InvokableCommandRectorTest extends AbstractRectorTestCase
final class InvokableCommandInputAttributeRectorTest extends AbstractRectorTestCase
{
#[DataProvider('provideData')]
public function test(string $filePath): void
Expand Down
10 changes: 10 additions & 0 deletions ...s/Symfony73/Rector/Class_/InvokableCommandInputAttributeRector/config/configured_rule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php

declare(strict_types=1);

use Rector\Config\RectorConfig;
use Rector\Symfony\Symfony73\Rector\Class_\InvokableCommandInputAttributeRector;

return static function (RectorConfig $rectorConfig): void {
$rectorConfig->rule(InvokableCommandInputAttributeRector::class);
};
10 changes: 0 additions & 10 deletions rules-tests/Symfony73/Rector/Class_/InvokableCommandRector/config/configured_rule.php
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions .../Rector/Class_/InvokableCommandRector.php → .../InvokableCommandInputAttributeRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@
* @see https://github.com/symfony/symfony-docs/issues/20553
* @see https://github.com/symfony/symfony/pull/59340
*
* @see \Rector\Symfony\Tests\Symfony73\Rector\Class_\InvokableCommandRector\InvokableCommandRectorTest
* @see \Rector\Symfony\Tests\Symfony73\Rector\Class_\InvokableCommandInputAttributeRector\InvokableCommandRectorTest
*/
final class InvokableCommandRector extends AbstractRector
final class InvokableCommandInputAttributeRector extends AbstractRector
{
private const MIGRATED_CONFIGURE_CALLS = ['addArgument', 'addOption'];

Expand Down
Loading