Skip to content

[Symfony73] Use class constant for use of Symfony\Component\Validator\Constraints\Collection #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 1 commit into from
Oct 14, 2025
Merged

[Symfony73] Use class constant for use of Symfony\Component\Validator\Constraints\Collection #852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion rules/Symfony73/Rector/Class_/ConstraintOptionsToNamedArgumentsRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
use PhpParser\Node\Name\FullyQualified;
use Rector\PhpParser\Node\Value\ValueResolver;
use Rector\Rector\AbstractRector;
use Rector\Symfony\Enum\SymfonyClass;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;

Expand Down Expand Up @@ -89,7 +90,7 @@ public function refactor(Node $node): ?Node
}

$args = $node->getArgs();
if ($className === 'Symfony\Component\Validator\Constraints\Collection'
if ($className === SymfonyClass::SYMFONY_VALIDATOR_CONSTRAINTS_COLLECTION
&& count($args) === 1
&& $args[0]->value instanceof Array_) {

Expand Down
5 changes: 5 additions & 0 deletions src/Enum/SymfonyClass.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,4 +150,9 @@ final class SymfonyClass
* @var string
*/
public const LOGOUT_SUCCESS_HANDLER = 'Symfony\Component\Security\Http\Logout\LogoutSuccessHandlerInterface';

/**
* @var string
*/
public const SYMFONY_VALIDATOR_CONSTRAINTS_COLLECTION = 'Symfony\Component\Validator\Constraints\Collection';
}