Skip to content

[Configs] Skip first class callable on RemoveConstructorAutowireServiceRector#858

Merged
samsonasik merged 3 commits intomainfrom
handle-crash-first
Oct 27, 2025
Merged

[Configs] Skip first class callable on RemoveConstructorAutowireServiceRector#858
samsonasik merged 3 commits intomainfrom
handle-crash-first

Conversation

@samsonasik
Copy link
Copy Markdown
Member

this cause notice:

There was 1 failure:

1) Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\RemoveConstructorAutowireServiceRectorTest::test with data set #2 ('/Users/samsonasik/www/rector-...hp.inc')
assert(!$this->isFirstClassCallable())

/Users/samsonasik/www/rector-symfony/vendor/nikic/php-parser/lib/PhpParser/Node/Expr/CallLike.php:32
/Users/samsonasik/www/rector-symfony/rules/Configs/Rector/Closure/RemoveConstructorAutowireServiceRector.php:212

this needs to be skipped.

@samsonasik
Copy link
Copy Markdown
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 309cada into main Oct 27, 2025
5 checks passed
@samsonasik samsonasik deleted the handle-crash-first branch October 27, 2025 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant