[CodeQuality] Skip Common Entity contains subnamespaces on ControllerMethodInjectionToConstructorRector#878
Merged
TomasVotruba merged 3 commits intomainfrom Nov 22, 2025
Merged
Conversation
…MethodInjectionToConstructorRector
…MethodInjectionToConstructorRector
…MethodInjectionToConstructorRector
Merged
Member
Author
|
All checks have passed 🎉 @TomasVotruba I think it is ready 👍 |
Member
|
LGTM 👍 |
samsonasik
commented
Nov 22, 2025
| /** | ||
| * @var string[] | ||
| */ | ||
| private const COMMON_ENTITY_CONTAINS_SUBNAMESPACES = ['\\Entity', '\\Document', '\\Model']; |
Member
Author
There was a problem hiding this comment.
The \\ prefix somehow removed under single quote on scoped build
rectorphp/rector@100442a#diff-2beb8610233424551baf38f6ba20dec69759c01de3abaa2ef4bd0f7f668079f1
On our usecase, this is still ok, but for future string related backslash usage that important(eg: regex), the double quote should be used.
Member
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #876 (review)
Entity classes can be fetched via ValueResolver services. This PR apply skip if the name contains
\\Entityor\\Documentor\\Model