[CodeQuality] Skip FOS\RestBundle ParamFetcher on ControllerMethodInjectionToConstructorRector#881
Merged
TomasVotruba merged 2 commits intomainfrom Nov 23, 2025
Merged
Conversation
…ectionToConstructorRector
Member
Author
|
Fixed 🎉 /cc @TomasVotruba |
Member
Author
|
All checks have passed 🎉 @TomasVotruba I think it is ready 👍 |
Member
|
👍 |
Member
|
Btw, what does this object do? Where does is come from? |
Member
Author
|
That seems used to fetch param from Rest under another service, that uses symfony RequestStack, that probably only exists during action call. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@TomasVotruba I tried in our project and it cause error:
this probably service created during call action.
This PR fix it.