Skip to content

[CodeQuality] Do not replace variable assign on ControllerMethodInjectionToConstructorRector#883

Merged
TomasVotruba merged 2 commits intomainfrom
do-not-replace
Nov 24, 2025
Merged

[CodeQuality] Do not replace variable assign on ControllerMethodInjectionToConstructorRector#883
TomasVotruba merged 2 commits intomainfrom
do-not-replace

Conversation

@samsonasik
Copy link
Copy Markdown
Member

when it re-assign variable from param, the variable assign should be kept, or it will cause error:

Fatal error: Uncaught Error: Cannot modify readonly property

see https://3v4l.org/BpX2t

@samsonasik
Copy link
Copy Markdown
Member Author

Fixed 🎉 /cc @TomasVotruba

@samsonasik
Copy link
Copy Markdown
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready 👍

@TomasVotruba
Copy link
Copy Markdown
Member

Nice edge case 👌

@TomasVotruba TomasVotruba merged commit 40e67e0 into main Nov 24, 2025
5 checks passed
@TomasVotruba TomasVotruba deleted the do-not-replace branch November 24, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants