Updated Rector to commit bc17200ed451d606aaebe40b2349d9675629a995

rectorphp/rector-src@bc17200 Fix ReplaceArgumentDefaultValueRector generating invalid self:: constant in unrelated classes (#8023)

Author: TomasVotruba

rules/Arguments/ArgumentDefaultValueReplacer.php

@@ -15,13 +15,15 @@
 use PhpParser\Node\Identifier;
 use PhpParser\Node\Name;
 use PhpParser\Node\Stmt\ClassMethod;
+use PHPStan\Reflection\ClassReflection;
 use Rector\Arguments\Contract\ReplaceArgumentDefaultValueInterface;
 use Rector\Arguments\ValueObject\ReplaceArgumentDefaultValue;
 use Rector\NodeAnalyzer\ArgsAnalyzer;
 use Rector\NodeTypeResolver\NodeTypeResolver;
 use Rector\PhpParser\AstResolver;
 use Rector\PhpParser\Node\NodeFactory;
 use Rector\PhpParser\Node\Value\ValueResolver;
+use Rector\Reflection\ReflectionResolver;
 use Rector\StaticTypeMapper\ValueObject\Type\FullyQualifiedObjectType;
 final class ArgumentDefaultValueReplacer
 {
@@ -45,13 +47,18 @@ final class ArgumentDefaultValueReplacer
      * @readonly
      */
     private NodeTypeResolver $nodeTypeResolver;
-    public function __construct(NodeFactory $nodeFactory, ValueResolver $valueResolver, ArgsAnalyzer $argsAnalyzer, AstResolver $astResolver, NodeTypeResolver $nodeTypeResolver)
+    /**
+     * @readonly
+     */
+    private ReflectionResolver $reflectionResolver;
+    public function __construct(NodeFactory $nodeFactory, ValueResolver $valueResolver, ArgsAnalyzer $argsAnalyzer, AstResolver $astResolver, NodeTypeResolver $nodeTypeResolver, ReflectionResolver $reflectionResolver)
     {
         $this->nodeFactory = $nodeFactory;
         $this->valueResolver = $valueResolver;
         $this->argsAnalyzer = $argsAnalyzer;
         $this->astResolver = $astResolver;
         $this->nodeTypeResolver = $nodeTypeResolver;
+        $this->reflectionResolver = $reflectionResolver;
     }
     /**
      * @template TCall as (MethodCall|StaticCall|ClassMethod|FuncCall|New_)
@@ -156,6 +163,18 @@ private function processArgs($expr, ReplaceArgumentDefaultValueInterface $replac
                     return null;
                 }
             }
+            // when the replacement value is a self::/static::/parent:: constant, it only
+            // resolves correctly if the class around the call actually has that constant;
+            // otherwise the produced code would reference a non-existing constant
+            if ($normalizedValueAfter instanceof ClassConstFetch && $normalizedValueAfter->class instanceof Name && $normalizedValueAfter->class->isSpecialClassName() && $normalizedValueAfter->name instanceof Identifier) {
+                $classReflection = $this->reflectionResolver->resolveClassReflection($expr);
+                if (!$classReflection instanceof ClassReflection) {
+                    return null;
+                }
+                if (!$classReflection->hasConstant($normalizedValueAfter->name->toString())) {
+                    return null;
+                }
+            }
             $particularArg->value = $normalizedValueAfter;
             return $expr;
         }

src/Application/VersionResolver.php

@@ -19,12 +19,12 @@ final class VersionResolver
      * @api
      * @var string
      */
-    public const PACKAGE_VERSION = '56fa09d6ace1b1cef0c5445be65fbedfdb61e0d9';
+    public const PACKAGE_VERSION = 'bc17200ed451d606aaebe40b2349d9675629a995';
     /**
      * @api
      * @var string
      */
-    public const RELEASE_DATE = '2026-06-02 21:16:56';
+    public const RELEASE_DATE = '2026-06-02 21:36:43';
     /**
      * @var int
      */

vendor/composer/autoload_classmap.php

@@ -2724,6 +2724,7 @@
     'Rector\\Symfony\\Symfony73\\Rector\\Class_\\GetFiltersToAsTwigFilterAttributeRector' => $vendorDir . '/rector/rector-symfony/rules/Symfony73/Rector/Class_/GetFiltersToAsTwigFilterAttributeRector.php',
     'Rector\\Symfony\\Symfony73\\Rector\\Class_\\GetFunctionsToAsTwigFunctionAttributeRector' => $vendorDir . '/rector/rector-symfony/rules/Symfony73/Rector/Class_/GetFunctionsToAsTwigFunctionAttributeRector.php',
     'Rector\\Symfony\\Symfony73\\Rector\\Class_\\InvokableCommandInputAttributeRector' => $vendorDir . '/rector/rector-symfony/rules/Symfony73/Rector/Class_/InvokableCommandInputAttributeRector.php',
+    'Rector\\Symfony\\Symfony73\\ValueObject\\AsTwigAttributeConversion' => $vendorDir . '/rector/rector-symfony/rules/Symfony73/ValueObject/AsTwigAttributeConversion.php',
     'Rector\\Symfony\\Symfony73\\ValueObject\\CommandArgument' => $vendorDir . '/rector/rector-symfony/rules/Symfony73/ValueObject/CommandArgument.php',
     'Rector\\Symfony\\Symfony73\\ValueObject\\CommandOption' => $vendorDir . '/rector/rector-symfony/rules/Symfony73/ValueObject/CommandOption.php',
     'Rector\\Symfony\\Symfony80\\Rector\\Class_\\RemoveEraseCredentialsRector' => $vendorDir . '/rector/rector-symfony/rules/Symfony80/Rector/Class_/RemoveEraseCredentialsRector.php',

vendor/composer/autoload_static.php

@@ -2984,6 +2984,7 @@ class ComposerStaticInit01276972c65a3d03f761e9dab07137cb
         'Rector\\Symfony\\Symfony73\\Rector\\Class_\\GetFiltersToAsTwigFilterAttributeRector' => __DIR__ . '/..' . '/rector/rector-symfony/rules/Symfony73/Rector/Class_/GetFiltersToAsTwigFilterAttributeRector.php',
         'Rector\\Symfony\\Symfony73\\Rector\\Class_\\GetFunctionsToAsTwigFunctionAttributeRector' => __DIR__ . '/..' . '/rector/rector-symfony/rules/Symfony73/Rector/Class_/GetFunctionsToAsTwigFunctionAttributeRector.php',
         'Rector\\Symfony\\Symfony73\\Rector\\Class_\\InvokableCommandInputAttributeRector' => __DIR__ . '/..' . '/rector/rector-symfony/rules/Symfony73/Rector/Class_/InvokableCommandInputAttributeRector.php',
+        'Rector\\Symfony\\Symfony73\\ValueObject\\AsTwigAttributeConversion' => __DIR__ . '/..' . '/rector/rector-symfony/rules/Symfony73/ValueObject/AsTwigAttributeConversion.php',
         'Rector\\Symfony\\Symfony73\\ValueObject\\CommandArgument' => __DIR__ . '/..' . '/rector/rector-symfony/rules/Symfony73/ValueObject/CommandArgument.php',
         'Rector\\Symfony\\Symfony73\\ValueObject\\CommandOption' => __DIR__ . '/..' . '/rector/rector-symfony/rules/Symfony73/ValueObject/CommandOption.php',
         'Rector\\Symfony\\Symfony80\\Rector\\Class_\\RemoveEraseCredentialsRector' => __DIR__ . '/..' . '/rector/rector-symfony/rules/Symfony80/Rector/Class_/RemoveEraseCredentialsRector.php',

vendor/composer/installed.json

@@ -1870,12 +1870,12 @@
             "source": {
                 "type": "git",
                 "url": "https:\/\/github.com\/rectorphp\/rector-symfony.git",
-                "reference": "39fb6b5918310a336dfba64a4624a54cea57eafc"
+                "reference": "96774903f6a0bd4891f74dc0cb682e529ef83581"
             },
             "dist": {
                 "type": "zip",
-                "url": "https:\/\/api.github.com\/repos\/rectorphp\/rector-symfony\/zipball\/39fb6b5918310a336dfba64a4624a54cea57eafc",
-                "reference": "39fb6b5918310a336dfba64a4624a54cea57eafc",
+                "url": "https:\/\/api.github.com\/repos\/rectorphp\/rector-symfony\/zipball\/96774903f6a0bd4891f74dc0cb682e529ef83581",
+                "reference": "96774903f6a0bd4891f74dc0cb682e529ef83581",
                 "shasum": ""
             },
             "require": {
@@ -1910,7 +1910,7 @@
                 "tomasvotruba\/unused-public": "^2.2",
                 "tracy\/tracy": "^2.12"
             },
-            "time": "2026-05-31T01:50:00+00:00",
+            "time": "2026-06-02T19:30:46+00:00",
             "default-branch": true,
             "type": "rector-extension",
             "extra": {