Skip to content

Commit 2660080

Browse files
committed
Updated Rector to commit 07d1687ba9e752d2b0cfdf3cdb29a90630d2e257
rectorphp/rector-src@07d1687 [DeadCode] Skip foreach over side-effecting expression in RemoveDeadIfForeachForRector (#8106)
1 parent 55c7f40 commit 2660080

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

rules/DeadCode/Rector/For_/RemoveDeadIfForeachForRector.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,10 @@ private function processForForeach($for, int $key, Node $stmtsAware): void
144144
$this->hasChanged = \true;
145145
return;
146146
}
147+
// the iterated expression itself may have side effects, e.g. foreach (generator() as $event) {}
148+
if ($this->hasNodeSideEffect($for->expr)) {
149+
return;
150+
}
147151
$exprs = [$for->expr, $for->valueVar, $for->valueVar];
148152
$variables = $this->betterNodeFinder->findInstanceOf($exprs, Variable::class);
149153
foreach ($variables as $variable) {

src/Application/VersionResolver.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,12 @@ final class VersionResolver
1919
* @api
2020
* @var string
2121
*/
22-
public const PACKAGE_VERSION = '2d0e0f178d7ed0b6f129063dd9d23a4ac2bd2cfb';
22+
public const PACKAGE_VERSION = '07d1687ba9e752d2b0cfdf3cdb29a90630d2e257';
2323
/**
2424
* @api
2525
* @var string
2626
*/
27-
public const RELEASE_DATE = '2026-06-29 08:32:01';
27+
public const RELEASE_DATE = '2026-06-29 10:48:15';
2828
/**
2929
* @var int
3030
*/

0 commit comments

Comments
 (0)