Updated Rector to commit 5be8f82d019842fb56fd0338da0b0569dbdf0bcb

rectorphp/rector-src@5be8f82 [injection] If parent class has dependency via promoted property, but its private, add a new one to child class deps (#7996)

Author: TomasVotruba

src/Application/VersionResolver.php

@@ -19,12 +19,12 @@ final class VersionResolver
      * @api
      * @var string
      */
-    public const PACKAGE_VERSION = '27c0087701a3668d9418f063f186ecdc3e561aa1';
+    public const PACKAGE_VERSION = '5be8f82d019842fb56fd0338da0b0569dbdf0bcb';
     /**
      * @api
      * @var string
      */
-    public const RELEASE_DATE = '2026-05-18 08:22:07';
+    public const RELEASE_DATE = '2026-05-18 12:15:58';
     /**
      * @var int
      */

src/NodeManipulator/ClassDependencyManipulator.php

@@ -3,11 +3,13 @@
 declare (strict_types=1);
 namespace Rector\NodeManipulator;
 
+use PhpParser\Modifiers;
 use PhpParser\Node\Arg;
 use PhpParser\Node\Expr\Assign;
 use PhpParser\Node\Expr\StaticCall;
 use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Name;
+use PhpParser\Node\Param;
 use PhpParser\Node\Stmt;
 use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\ClassLike;
@@ -200,12 +202,27 @@ private function addPromotedProperty(Class_ $class, PropertyMetadata $propertyMe
     {
         $param = $this->nodeFactory->createPromotedPropertyParam($propertyMetadata);
         if ($constructClassMethod instanceof ClassMethod) {
-            // parameter is already added
-            if ($this->hasMethodParameter($constructClassMethod, $propertyMetadata->getName())) {
+            $hasOwnConstruct = $class->getMethod(MethodName::CONSTRUCT) instanceof ClassMethod;
+            $matchedParam = $this->matchMethodParameter($constructClassMethod, $propertyMetadata->getName());
+            if ($matchedParam instanceof Param) {
+                // own constructor already has this param → nothing to do
+                if ($hasOwnConstruct) {
+                    return;
+                }
+                // parent constructor has a same-named param; if it is a private promoted
+                // property, the child cannot access it via $this — add a fresh constructor
+                // on the child instead of trying to extend the parent signature
+                if (($matchedParam->flags & Modifiers::PRIVATE) !== 0) {
+                    $childConstructClassMethod = $this->nodeFactory->createPublicMethod(MethodName::CONSTRUCT);
+                    $childConstructClassMethod->params[] = $param;
+                    $this->classInsertManipulator->addAsFirstMethod($class, $childConstructClassMethod);
+                    return;
+                }
+                // parent's matching param is protected/public — accessible from child, no add needed
                 return;
             }
             // found construct, but only on parent, add to current class
-            if (!$class->getMethod(MethodName::CONSTRUCT) instanceof ClassMethod) {
+            if (!$hasOwnConstruct) {
                 $parentArgs = [];
                 foreach ($constructClassMethod->params as $originalParam) {
                     $parentArgs[] = new Arg(new Variable((string) $this->nodeNameResolver->getName($originalParam->var)));
@@ -265,14 +282,14 @@ private function hasClassPropertyAndDependency(Class_ $class, PropertyMetadata $
         // is inject/autowired property?
         return $property instanceof Property;
     }
-    private function hasMethodParameter(ClassMethod $classMethod, string $name): bool
+    private function matchMethodParameter(ClassMethod $classMethod, string $name): ?Param
     {
         foreach ($classMethod->params as $param) {
             if ($this->nodeNameResolver->isName($param->var, $name)) {
-                return \true;
+                return $param;
             }
         }
-        return \false;
+        return null;
     }
     private function shouldAddPromotedProperty(Class_ $class, PropertyMetadata $propertyMetadata): bool
     {