Updated Rector to commit c4b68d5fd646875fa96f68941e4b2b643a06d1f8

rectorphp/rector-src@c4b68d5  [Php70] Handle class named Pool on Php4ConstructorRector  (#6887)

Author: TomasVotruba

vendor/composer/installed.json

@@ -1866,12 +1866,12 @@
             "source": {
                 "type": "git",
                 "url": "https:\/\/github.com\/rectorphp\/rector-symfony.git",
-                "reference": "9f83efbeb0b555ddc790199cfec6a8fe18c72eb7"
+                "reference": "3234dd8a2a60c0deb6e232a7c820b20a8e7a4726"
             },
             "dist": {
                 "type": "zip",
-                "url": "https:\/\/api.github.com\/repos\/rectorphp\/rector-symfony\/zipball\/9f83efbeb0b555ddc790199cfec6a8fe18c72eb7",
-                "reference": "9f83efbeb0b555ddc790199cfec6a8fe18c72eb7",
+                "url": "https:\/\/api.github.com\/repos\/rectorphp\/rector-symfony\/zipball\/3234dd8a2a60c0deb6e232a7c820b20a8e7a4726",
+                "reference": "3234dd8a2a60c0deb6e232a7c820b20a8e7a4726",
                 "shasum": ""
             },
             "require": {
@@ -1900,7 +1900,7 @@
                 "tomasvotruba\/unused-public": "^2.0",
                 "tracy\/tracy": "^2.10"
             },
-            "time": "2025-05-07T11:24:29+00:00",
+            "time": "2025-05-07T12:42:13+00:00",
             "default-branch": true,
             "type": "rector-extension",
             "extra": {

vendor/composer/installed.php

@@ -9,7 +9,7 @@
  */
 final class GeneratedConfig
 {
-    public const EXTENSIONS = array('rector/rector-doctrine' => array('install_path' => '/home/runner/work/rector-src/rector-src/rector-build/vendor/rector/rector-doctrine', 'relative_install_path' => '../../rector-doctrine', 'extra' => NULL, 'version' => 'dev-main 826f808'), 'rector/rector-downgrade-php' => array('install_path' => '/home/runner/work/rector-src/rector-src/rector-build/vendor/rector/rector-downgrade-php', 'relative_install_path' => '../../rector-downgrade-php', 'extra' => NULL, 'version' => 'dev-main 2b141c8'), 'rector/rector-phpunit' => array('install_path' => '/home/runner/work/rector-src/rector-src/rector-build/vendor/rector/rector-phpunit', 'relative_install_path' => '../../rector-phpunit', 'extra' => NULL, 'version' => 'dev-main 96b3565'), 'rector/rector-symfony' => array('install_path' => '/home/runner/work/rector-src/rector-src/rector-build/vendor/rector/rector-symfony', 'relative_install_path' => '../../rector-symfony', 'extra' => NULL, 'version' => 'dev-main 9f83efb'));
+    public const EXTENSIONS = array('rector/rector-doctrine' => array('install_path' => '/home/runner/work/rector-src/rector-src/rector-build/vendor/rector/rector-doctrine', 'relative_install_path' => '../../rector-doctrine', 'extra' => NULL, 'version' => 'dev-main 826f808'), 'rector/rector-downgrade-php' => array('install_path' => '/home/runner/work/rector-src/rector-src/rector-build/vendor/rector/rector-downgrade-php', 'relative_install_path' => '../../rector-downgrade-php', 'extra' => NULL, 'version' => 'dev-main 2b141c8'), 'rector/rector-phpunit' => array('install_path' => '/home/runner/work/rector-src/rector-src/rector-build/vendor/rector/rector-phpunit', 'relative_install_path' => '../../rector-phpunit', 'extra' => NULL, 'version' => 'dev-main 96b3565'), 'rector/rector-symfony' => array('install_path' => '/home/runner/work/rector-src/rector-src/rector-build/vendor/rector/rector-symfony', 'relative_install_path' => '../../rector-symfony', 'extra' => NULL, 'version' => 'dev-main 3234dd8'));
     private function __construct()
     {
     }

vendor/rector/extension-installer/src/GeneratedConfig.php

@@ -3,6 +3,7 @@
 declare (strict_types=1);
 namespace Rector\Symfony\CodeQuality\Rector\ClassMethod;
 
+use PhpParser\Node\Expr\New_;
 use PhpParser\Node;
 use PhpParser\Node\Attribute;
 use PhpParser\Node\Expr;
@@ -37,6 +38,7 @@
 use Rector\Symfony\NodeFinder\EmptyReturnNodeFinder;
 use Rector\Symfony\TypeAnalyzer\ArrayUnionResponseTypeAnalyzer;
 use Rector\Symfony\TypeDeclaration\ReturnTypeDeclarationUpdater;
+use RectorPrefix202505\Symfony\Component\HttpFoundation\Response;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 /**
@@ -261,7 +263,14 @@ private function refactorReturnWithValue(Return_ $return, bool $hasThisRenderOrR
         /** @var Expr $lastReturnExpr */
         $lastReturnExpr = $return->expr;
         $returnStaticType = $this->getType($lastReturnExpr);
-        if (!$return->expr instanceof MethodCall) {
+        // is new response? keep it
+        $isResponseType = \false;
+        if ($return->expr instanceof New_) {
+            $new = $return->expr;
+            if ($this->isObjectType($new->class, new ObjectType(Response::class))) {
+                $isResponseType = \true;
+            }
+        } elseif (!$return->expr instanceof MethodCall) {
             if (!$hasThisRenderOrReturnsResponse || $returnStaticType instanceof ConstantArrayType) {
                 $return->expr = $thisRenderMethodCall;
             }
@@ -273,7 +282,7 @@ private function refactorReturnWithValue(Return_ $return, bool $hasThisRenderOrR
         }
         $isArrayOrResponseType = $this->arrayUnionResponseTypeAnalyzer->isArrayUnionResponseType($returnStaticType, SymfonyClass::RESPONSE);
         // skip as the original class method has to change first
-        if ($isArrayOrResponseType) {
+        if ($isArrayOrResponseType && $isResponseType === \false) {
             return \false;
         }
         // already response

vendor/rector/rector-symfony/rules/CodeQuality/Rector/ClassMethod/TemplateAnnotationToThisRenderRector.php

@@ -3,6 +3,7 @@
 declare (strict_types=1);
 namespace Rector\Symfony\NodeFactory\Annotations;
 
+use PhpParser\Node\Identifier;
 use PhpParser\Node\Arg;
 use PhpParser\Node\Attribute;
 use PhpParser\Node\Scalar\String_;
@@ -53,7 +54,7 @@ public function resolve($tagValueNodeOrAttribute, string $desiredKey)
     }
     private function isKeyEmptyOrMatch(Arg $attributeArg, string $desiredKey) : bool
     {
-        if ($attributeArg->name === null) {
+        if (!$attributeArg->name instanceof Identifier) {
             return \true;
         }
         return $attributeArg->name->toString() === $desiredKey;