Updated Rector to commit eebd08648851e64a18c19c62710546c14729da00

rectorphp/rector-src@eebd086 [Php81] Skip readonly on property returned by reference in ReadOnlyPropertyRector (#8108)

Author: TomasVotruba

rules/Php81/Rector/Property/ReadOnlyPropertyRector.php

@@ -13,6 +13,7 @@
 use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\Node\Stmt\Property;
+use PhpParser\Node\Stmt\Return_;
 use PhpParser\NodeVisitor;
 use PHPStan\Analyser\Scope;
 use PHPStan\PhpDocParser\Ast\PhpDoc\GenericTagValueNode;
@@ -176,6 +177,10 @@ private function refactorProperty(Class_ $class, Property $property, Scope $scop
         if ($this->propertyFetchAssignManipulator->isAssignedMultipleTimesInConstructor($class, $property)) {
             return null;
         }
+        // returned by reference can be mutated outside the class, so it cannot be readonly
+        if ($this->isPropertyReturnedByRef($class, (string) $this->getName($property))) {
+            return null;
+        }
         $this->visibilityManipulator->makeReadonly($property);
         $this->removeReadOnlyDoc($property);
         return $property;
@@ -226,10 +231,33 @@ private function refactorParam(Class_ $class, ClassMethod $classMethod, Param $p
         if ($this->isPromotedPropertyAssigned($class, $param)) {
             return null;
         }
+        // returned by reference can be mutated outside the class, so it cannot be readonly
+        if ($this->isPropertyReturnedByRef($class, (string) $this->getName($param))) {
+            return null;
+        }
         $this->visibilityManipulator->makeReadonly($param);
         $this->removeReadOnlyDoc($param);
         return $param;
     }
+    private function isPropertyReturnedByRef(Class_ $class, string $propertyName): bool
+    {
+        foreach ($class->getMethods() as $classMethod) {
+            if (!$classMethod->byRef) {
+                continue;
+            }
+            $returns = $this->betterNodeFinder->findInstanceOf($classMethod, Return_::class);
+            foreach ($returns as $return) {
+                if (!$return->expr instanceof Expr) {
+                    continue;
+                }
+                $propertyFetch = $this->betterNodeFinder->findFirst($return->expr, fn(Node $subNode): bool => $subNode instanceof PropertyFetch && $this->isName($subNode->var, 'this') && $this->isName($subNode, $propertyName));
+                if ($propertyFetch instanceof PropertyFetch) {
+                    return \true;
+                }
+            }
+        }
+        return \false;
+    }
     private function isPromotedPropertyAssigned(Class_ $class, Param $param): bool
     {
         $constructClassMethod = $class->getMethod(MethodName::CONSTRUCT);

src/Application/VersionResolver.php

@@ -19,12 +19,12 @@ final class VersionResolver
      * @api
      * @var string
      */
-    public const PACKAGE_VERSION = '0180e9bb149b532f2864c60bf255b04bf75107f0';
+    public const PACKAGE_VERSION = 'eebd08648851e64a18c19c62710546c14729da00';
     /**
      * @api
      * @var string
      */
-    public const RELEASE_DATE = '2026-06-29 11:16:35';
+    public const RELEASE_DATE = '2026-06-29 11:18:40';
     /**
      * @var int
      */