Incorrect behavior of PreferPHPUnitSelfCallRector, PreferPHPUnitThisCallRector

[andrew-demb]

Bug Report

Subject	Details
Rector version	last dev-main
Installed as	composer dependency

Minimal PHP Code Causing Issue

See https://getrector.com/demo/442c80c1-aae0-4ee6-aacb-c3dec50e5db4

<?php

// PreferPHPUnitSelfCallRector
final class DemoFile extends \PHPUnit\Framework\TestCase
{
    public function testSuccess(): void
    {
        $mock = $this->createMock(\stdClass::class);
        
        $this->assertTrue(true);
    }
}

Responsible rules

• PreferPHPUnitSelfCallRector

• PreferPHPUnitThisCallRector

Expected Behavior

Rector should change to use self only static methods, not all of them.

createMock method is not static

[samsonasik]

Call non-static method with self from inside current object is fine https://3v4l.org/Ghuj1, this is by preference and on purpose for consistency, see list of methods on

https://github.com/rectorphp/rector-phpunit/blob/10f60e1cf4a3a22ac841ed871d5f0e083516e8ad/rules/CodeQuality/Enum/NonAssertStaticableMethods.php#L7-L13

You can place PreferPHPUnitThisCallRector later after withPreparedSets() so it kept as $this

https://getrector.com/demo/37a03d38-5e08-4654-afa9-0a5ca0ceb27d

[andrew-demb]

@samsonasik I prefer to have all static methods to be called as static, even if PHP works with both ways.

So I can't consider this behavior as an expected

[samsonasik]

Feel free to create PR for this, ensure it both works on PreferPHPUnitThisCallRector and PreferPHPUnitSelfCallRector

[andrew-demb]

Here is it rectorphp/rector-phpunit#482

[github-actions]

This issue has been automatically locked because it has been closed for 150 days. Please open a new issue if you have a similar problem.