Incorrect behavior of InvokableCommandInputAttributeRector

[darthf1]

Bug Report

Subject	Details
Rector version	last dev-main
Installed as	composer dependency

Minimal PHP Code Causing Issue

See https://getrector.com/demo/7268bb7d-7a4f-4485-b43e-c5cb83a4c65b

<?php

use Symfony\Component\Console\Attribute\AsCommand;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Style\SymfonyStyle;

#[AsCommand('app:my-command')]
final class MyCommand extends Command
{
    #[\Override]
    protected function execute(InputInterface $input, OutputInterface $output): int
    {
        $io = new SymfonyStyle($input, $output);
	$io->info('Great success!');

	return 1;
    }
}

Responsible rules

• InvokableCommandInputAttributeRector

Expected Behavior

 use Symfony\Component\Console\Style\SymfonyStyle;
 
 #[AsCommand('app:my-command')]
-final class MyCommand extends Command
+final class MyCommand
 {
     #[\Override]
-    protected function execute(InputInterface $input, OutputInterface $output): int
-    {
-        $io = new SymfonyStyle($input, $output);
-	 $io->info('Great success!');
-
-	return 1;
+    public function __invoke(\Symfony\Component\Console\Style\SymfonyStyle $io): int
+    {
+        $io->info('Great success!');
+        return 1;
     }
 }

[samsonasik]

Please create input + expected fixture PR at https://github.com/rectorphp/rector-symfony/tree/main/rules-tests/Symfony73/Rector/Class_/InvokableCommandInputAttributeRector/Fixture , thank you.

[darthf1]

Ofc! Fixture at rectorphp/rector-symfony#811

[cb-constructiva]

To add to this issue, the rule removes the shorthand and description of an option.
As well as weird behaviour in the __invoke function itself.
https://getrector.com/demo/f24cb710-4d38-4d93-8006-fdb5b3f8329a

[TomasVotruba]

I'm looking into this...

[samsonasik]

@TomasVotruba there is already fixture PR test for it:

• InvokableCommandInputAttributeRector test fixture rector-symfony#811

[TomasVotruba]

Fixed in rectorphp/rector-symfony#838

[TomasVotruba]

@cb-constructiva Looking into your report as well... 👍

[TomasVotruba]

@cb-constructiva Resolved in rectorphp/rector-symfony#839 👍