Fix generic-object false positive

Author: staabm

src/Rules/NarrowPrivateClassMethodParamTypeRule.php

@@ -22,6 +22,7 @@
 use PHPStan\Type\MixedType;
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\UnionType;
+use PHPStan\Type\Generic\GenericObjectType;
 use PHPStan\Type\VerbosityLevel;
 use Rector\TypePerfect\Configuration;
 use Rector\TypePerfect\NodeFinder\ClassMethodNodeFinder;
@@ -149,7 +150,7 @@ private function validateParam(Param $param, int $position, Expr $expr, Scope $s
             return null;
         }
 
-        if ($argType instanceof IntersectionType) {
+        if ($argType instanceof IntersectionType || $argType instanceof GenericObjectType) {
             return null;
         }
 

tests/Rules/NarrowPrivateClassMethodParamTypeRule/Fixture/SkipSameGeneric.php

@@ -0,0 +1,34 @@
+<?php
+
+namespace Rector\TypePerfect\Tests\Rules\NarrowPrivateClassMethodParamTypeRule\Fixture;
+
+
+use Rector\TypePerfect\Tests\Rules\NarrowPrivateClassMethodParamTypeRule\Source\MyIterator;
+use Rector\TypePerfect\Tests\Rules\NarrowPrivateClassMethodParamTypeRule\Source\MyPreise;
+
+final class SkipSameGeneric
+{
+    protected function getPriceAndCalculateTableVM(): void
+    {
+
+        $prices = $this->getPricesForArticle();
+        $this->getAmounts($prices);
+    }
+
+    /**
+     * @param MyIterator<MyPreise> $prices
+     */
+    private function getAmounts(MyIterator $prices): void
+    {
+    }
+
+    /**
+     * @return MyIterator<MyPreise>
+     */
+    private function getPricesForArticle(): MyIterator
+    {
+        /** @var MyIterator<MyPreise> */
+        return new MyIterator();
+    }
+
+}

tests/Rules/NarrowPrivateClassMethodParamTypeRule/NarrowPrivateClassMethodParamTypeRuleTest.php

@@ -51,6 +51,7 @@ public static function provideData(): Iterator
         yield [__DIR__ . '/Fixture/SkipGenericType.php', []];
         yield [__DIR__ . '/Fixture/SkipAbstractBase.php', []];
         yield [__DIR__ . '/Fixture/SkipVariadics.php', []];
+        yield [__DIR__ . '/Fixture/SkipSameGeneric.php', []];
     }
 
     /**

tests/Rules/NarrowPrivateClassMethodParamTypeRule/Source/MyIterator.php

@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\TypePerfect\Tests\Rules\NarrowPrivateClassMethodParamTypeRule\Source;
+
+/**
+ * @template T
+ */
+final class MyIterator
+{
+}

tests/Rules/NarrowPrivateClassMethodParamTypeRule/Source/MyPreise.php

@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\TypePerfect\Tests\Rules\NarrowPrivateClassMethodParamTypeRule\Source;
+
+class MyPreise
+{
+}