NarrowPublicClassMethodParamTypeRule: Fix generic-object false-positive (#74)

* NarrowPublicClassMethodParamTypeRule: Fix generic-object false-positive

* Update CollectorMetadataPrinter.php

* Update CollectorMetadataPrinter.php

Author: staabm

src/Printer/CollectorMetadataPrinter.php

@@ -19,6 +19,7 @@
 use PHPStan\Reflection\ExtendedMethodReflection;
 use PHPStan\Reflection\ParametersAcceptorSelector;
 use PHPStan\Type\ClosureType;
+use PHPStan\Type\Generic\GenericObjectType;
 use PHPStan\Type\IntegerRangeType;
 use PHPStan\Type\IntersectionType;
 use PHPStan\Type\MixedType;
@@ -65,6 +66,10 @@ public function printArgTypesAsString(
                 return ResolvedTypes::UNKNOWN_TYPES;
             }
 
+            if ($argType instanceof GenericObjectType) {
+                return ResolvedTypes::UNKNOWN_TYPES;
+            }
+
             if ($argType instanceof PHPStanUnionType) {
                 return ResolvedTypes::UNKNOWN_TYPES;
             }

tests/Rules/NarrowPublicClassMethodParamTypeRule/Fixture/Generics/SkipSameGeneric.php

@@ -0,0 +1,19 @@
+<?php
+
+namespace Rector\TypePerfect\Tests\Rules\NarrowPublicClassMethodParamTypeRule\Fixture\Generics;
+
+use Rector\TypePerfect\Tests\Rules\NarrowPublicClassMethodParamTypeRule\Source\SkipSameGeneric\MyGroup;
+use Rector\TypePerfect\Tests\Rules\NarrowPublicClassMethodParamTypeRule\Source\SkipSameGeneric\MyIterator;
+
+final class SkipSameGeneric
+{
+    /**
+     * @param MyIterator<MyGroup> $_werbemasse
+     */
+    public function setWerbemasse($_werbemasse): void
+    {
+        $this->_werbemasse = $_werbemasse;
+    }
+}
+
+

tests/Rules/NarrowPublicClassMethodParamTypeRule/NarrowPublicClassMethodParamTypeRuleTest.php

@@ -160,6 +160,14 @@ public static function provideData(): Iterator
 
         $argErrorMessage = sprintf(NarrowPublicClassMethodParamTypeRule::ERROR_MESSAGE, 'bool');
         yield [[__DIR__ . '/Fixture/ExplicitlyNullableParams.php'], [[$argErrorMessage, 9]]];
+
+        // skip generics
+        yield [[
+            __DIR__ . '/Fixture/Generics/SkipSameGeneric.php',
+            __DIR__ . '/Source/SkipSameGeneric/MyGroup.php',
+            __DIR__ . '/Source/SkipSameGeneric/MyIterator.php',
+            __DIR__ . '/Source/SkipSameGeneric/MyService.php',
+        ], []];
     }
 
     /**

tests/Rules/NarrowPublicClassMethodParamTypeRule/Source/SkipSameGeneric/MyGroup.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\TypePerfect\Tests\Rules\NarrowPublicClassMethodParamTypeRule\Source\SkipSameGeneric;
+
+final class MyGroup
+{
+
+}

tests/Rules/NarrowPublicClassMethodParamTypeRule/Source/SkipSameGeneric/MyIterator.php

@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\TypePerfect\Tests\Rules\NarrowPublicClassMethodParamTypeRule\Source\SkipSameGeneric;
+
+/**
+ * @template T
+ */
+final class MyIterator
+{
+}

tests/Rules/NarrowPublicClassMethodParamTypeRule/Source/SkipSameGeneric/MyService.php

@@ -0,0 +1,26 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\TypePerfect\Tests\Rules\NarrowPublicClassMethodParamTypeRule\Source\SkipSameGeneric;
+
+use Rector\TypePerfect\Tests\Rules\NarrowPublicClassMethodParamTypeRule\Fixture\Generics\SkipSameGeneric;
+
+final class MyService
+{
+
+    private SkipSameGeneric $articleModel;
+
+    private function populateCustomizationDimensions(int $spracheid): void
+    {
+        $this->articleModel->setWerbemasse($this->fetchCustomizationPositionsByArtidAndSprache());
+    }
+
+    /**
+     * @return MyIterator<MyGroup>
+     */
+    public function fetchCustomizationPositionsByArtidAndSprache(int $artid, int $spracheid): MyIterator
+    {
+    }
+
+}