Skip to content

Commit 88ca329

Browse files
[RTY-260028]: Merge branch 'feature/RTY-260025' into bugfix/RTY-260028
2 parents 96acea6 + c95db2a commit 88ca329

File tree

2 files changed

+11
-23
lines changed

2 files changed

+11
-23
lines changed

app/routes.py

Lines changed: 6 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ async def index(request: Request):
5757

5858
new_short_url = session.pop("new_short_url", None)
5959
qr_enabled = session.pop("qr_enabled", False)
60-
qr_type = session.pop("qr_type", "short")
6160
original_url = session.pop("original_url", None)
6261
short_code = session.pop("short_code", None)
6362
info_message = session.pop("info_message", None)
@@ -67,7 +66,7 @@ async def index(request: Request):
6766
qr_data = None
6867

6968
if qr_enabled and new_short_url and short_code:
70-
qr_data = new_short_url if qr_type == "short" else original_url
69+
qr_data = new_short_url
7170
qr_filename = f"{short_code}.png"
7271
PROJECT_ROOT = BASE_DIR.parent # go from app/ → project root
7372
qr_dir = PROJECT_ROOT / "assets" / "images" / "qr"
@@ -235,44 +234,30 @@ def delete_recent_api(short_code: str):
235234
recent = get_recent_from_cache(MAX_RECENT_URLS) or []
236235
removed_from_cache = False
237236

238-
# Try removing from cache (memory only)
239237
for i, item in enumerate(recent):
240238
code = item.get("short_code") or item.get("code")
241239
if code == short_code:
242-
recent.pop(i)
243240
removed_from_cache = True
244241
break
245242

246243
db_available = db.is_connected()
247244
db_deleted = False
248245

249-
# If DB available → rely ONLY on DB
250246
if db_available:
251247
db_deleted = db.delete_by_short_code(short_code)
252248

253-
if not db_deleted:
254-
raise HTTPException(
255-
status_code=404, detail=f"short_code '{short_code}' not found"
256-
)
257-
258-
return {
259-
"status": "deleted",
260-
"short_code": short_code,
261-
"db_deleted": True,
262-
"db_available": True,
263-
}
264-
265-
# If DB NOT available → rely on cache only
266-
if not removed_from_cache:
249+
# ✅ If nothing was deleted anywhere → 404
250+
if not removed_from_cache and not db_deleted:
267251
raise HTTPException(
268252
status_code=404, detail=f"short_code '{short_code}' not found"
269253
)
270254

271255
return {
256+
"success": True,
272257
"status": "deleted",
273258
"short_code": short_code,
274-
"db_deleted": False,
275-
"db_available": False,
259+
"db_deleted": db_deleted,
260+
"db_available": db_available,
276261
}
277262

278263

app/templates/index.html

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,11 @@ <h1>tiny URL</h1>
1919
<div>
2020
<span class="ready-label">Ready</span>
2121
<div class="short-url">
22-
<a href="{{ new_short_url }}" id="shortUrlDisplay" style="text-decoration: underline;">
22+
<a href="{{ new_short_url }}" id="shortUrlDisplay" style="text-decoration: underline;" target="_blank"
23+
rel="noopener noreferrer">
2324
{{ new_short_url }}
2425
</a>
26+
</a>
2527
</div>
2628
</div>
2729
</div>
@@ -30,7 +32,8 @@ <h1>tiny URL</h1>
3032
%} </div>
3133
</div> {% endif %} <div class="recent-tray">
3234
<div class="recent-header">
33-
<h3>Recently Shortened</h3> <a href="/recent" class="history-link">View History →</a>
35+
<h3>Recently Shortened</h3>
36+
<a href="/recent" class="history-link" target="_blank">View History →</a>
3437
</div>
3538
<div class="scroll-container"> {% for url in urls %} <div class="recent-item">
3639
<div class="short-code">/{{ url.short_code }}</div>

0 commit comments

Comments
 (0)