Make Docker build successful and update base image#305
Merged
Conversation
Because the `version` field is no longer required in Docker Compose v2. This patch will suppress the following warning: ```console $ docker compose build WARN[0000] the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion ```
Because Jupyter images hosted on Docker Hub are no longer updated. This patch will resolve the following error: ```console $ docker compose build (snip) failed to solve: jupyter/minimal-notebook:3692e3a84cd6: failed to resolve source metadata for docker.io/jupyter/minimal-notebook:3692e3a84cd6: docker.io/jupyter/minimal-notebook:3692e3a84cd6: not found ```
Since e04839b, Gemfile.lock file is deleted. This patch will resolve the following error: ```console $ docker compose build (snip) => ERROR [minimal-redamber 7/9] COPY --chown=1000:100 Gemfile.lock /home/jovyan ```
Since e04839b, example script is moved to bin directory. bin directory is not accessible in the container. Because compose.yml's context is `.` (`.` means docker directory).
This patch will resolve an occurred error while installing psych.
Member
|
Is the build container / build failure unrelated? |
Contributor
Author
|
Yes, unrelated. The build container / build failure that root cause is may unable to red_amber/.devcontainer/Dockerfile Line 75 in d0100e0
I would like to open a separate PR. |
Member
|
OK. Let's work on it a separated task. |
Contributor
Author
|
Thanks for your review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes: