Update catalog Dockerfiles: swap llm-d component labels#24270
Merged
Conversation
Replace offboarded llm-d-inference-scheduler and llm-d-routing-sidecar ARGs and labels with the new llm-d-router-endpoint-picker and llm-d-router-disagg-sidecar in all 4 catalog Dockerfiles (v4.19-v4.22). The onboarding skill updated the bundle Dockerfile but skipped the catalog Dockerfiles. Without these labels, the tracer cannot map images to git commits for the new components. Jira: RHOAIENG-69738, RHOAIENG-69343 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the OpenShift catalog (FBC) Dockerfiles to reflect llm-d component offboarding/onboarding by replacing legacy llm-d component build args/labels with the new router endpoint-picker and disagg-sidecar identifiers, so downstream tooling (e.g., tracer) can map images back to git commits consistently across supported OCP versions.
Changes:
- Replaced
ODH_LLM_D_INFERENCE_SCHEDULER_*/ODH_LLM_D_ROUTING_SIDECAR_*build ARGs withODH_LLM_D_ROUTER_ENDPOINT_PICKER_*/ODH_LLM_D_ROUTER_DISAGG_SIDECAR_*in catalog Dockerfiles. - Updated corresponding
LABELentries fromodh-llm-d-inference-scheduler/odh-llm-d-routing-sidecartoodh-llm-d-router-endpoint-picker/odh-llm-d-router-disagg-sidecaracross v4.19–v4.22.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| catalog/v4.19/Dockerfile | Swaps llm-d scheduler/sidecar ARGs+labels to router endpoint-picker/disagg-sidecar for v4.19 catalog. |
| catalog/v4.20/Dockerfile | Same llm-d ARG/label swap for v4.20 catalog. |
| catalog/v4.21/Dockerfile | Same llm-d ARG/label swap for v4.21 catalog. |
| catalog/v4.22/Dockerfile | Same llm-d ARG/label swap for v4.22 catalog. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Peterk04
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
llm-d-inference-schedulerandllm-d-routing-sidecarARGs and labels with newllm-d-router-endpoint-pickerandllm-d-router-disagg-sidecarin all 4 catalog Dockerfiles (v4.19, v4.20, v4.21, v4.22)bundle/Dockerfileandhelm/xks-values-patch.yamlJira
Test plan
grep -r "inference.scheduler\|routing.sidecar" catalog/v4.*/Dockerfilegrep -r "endpoint.picker\|disagg.sidecar" catalog/v4.*/Dockerfile