Skip to content

Commit 4977c16

Browse files
authored
Merge pull request #75 from opendatahub-io/zhao-doc
docs: use OCI chart v0.2.0 and RHOAI images as default for deploy-rhoai
2 parents 2dbc884 + 00e5dc2 commit 4977c16

4 files changed

Lines changed: 50 additions & 24 deletions

File tree

docs/guides/deploy-rhoai.md

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -987,10 +987,11 @@ oc create secret generic batch-gateway-secrets \
987987
<summary>Install batch-gateway</summary>
988988

989989
```bash
990-
IMAGE_TAG=odh-stable
991-
APISERVER_REPO=quay.io/opendatahub/odh-llm-d-batch-gateway-apiserver
992-
PROCESSOR_REPO=quay.io/opendatahub/odh-llm-d-batch-gateway-processor
993-
GC_REPO=quay.io/opendatahub/odh-llm-d-batch-gateway-gc
990+
CHART_VERSION=0.2.0
991+
IMAGE_TAG=rhoai-3.5-ea.2
992+
APISERVER_REPO=quay.io/rhoai/odh-llm-d-batch-gateway-apiserver-rhel9
993+
PROCESSOR_REPO=quay.io/rhoai/odh-llm-d-batch-gateway-processor-rhel9
994+
GC_REPO=quay.io/rhoai/odh-llm-d-batch-gateway-gc-rhel9
994995
```
995996

996997
```bash
@@ -1000,8 +1001,10 @@ INTERNAL_GW_SVC=$(oc get svc -n openshift-ingress \
10001001
-o jsonpath='{.items[0].metadata.name}')
10011002
MODEL_URL="http://${INTERNAL_GW_SVC}.openshift-ingress.svc.cluster.local/${LLM_NS}/${ISVC_NAME}"
10021003

1003-
# Install batch-gateway
1004-
helm upgrade --install batch-gateway ./charts/batch-gateway \
1004+
# Install batch-gateway from OCI chart
1005+
helm upgrade --install batch-gateway \
1006+
oci://ghcr.io/llm-d-incubation/charts/batch-gateway \
1007+
--version ${CHART_VERSION} \
10051008
--namespace ${BATCH_NS} \
10061009
--set "apiserver.image.repository=${APISERVER_REPO}" \
10071010
--set "apiserver.image.tag=${IMAGE_TAG}" \

examples/deploy-demo/common.sh

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -578,7 +578,8 @@ install_batch_gateway() {
578578

579579
local chart version_args=()
580580
if [ -n "${BATCH_RELEASE_VERSION}" ]; then
581-
chart="oci://ghcr.io/llm-d/charts/batch-gateway"
581+
# TODO: pre-graduation location; update to ghcr.io/llm-d in the next release
582+
chart="oci://ghcr.io/llm-d-incubation/charts/batch-gateway"
582583
version_args=(--version "${BATCH_RELEASE_VERSION#v}")
583584
elif [ "${BATCH_DEV_VERSION}" = "local" ]; then
584585
local repo_root
@@ -628,7 +629,20 @@ install_batch_gateway() {
628629
fi
629630
done
630631
if [ "${mismatch}" = "true" ]; then
631-
warn "Image tags do not match expected version."
632+
die "Image tags do not match expected version."
633+
fi
634+
635+
# Verify OCI chart version for release installs
636+
if [ -n "${BATCH_RELEASE_VERSION}" ]; then
637+
local installed_ver
638+
installed_ver=$(helm get metadata "${BATCH_HELM_RELEASE}" -n "${BATCH_NAMESPACE}" -o json 2>/dev/null \
639+
| jq -r '.version // empty')
640+
local expected_ver="${BATCH_RELEASE_VERSION#v}"
641+
if [ "${installed_ver}" = "${expected_ver}" ]; then
642+
log "Verified: OCI chart version ${installed_ver} matches release ${BATCH_RELEASE_VERSION}"
643+
else
644+
die "Chart version '${installed_ver}' does not match expected '${expected_ver}'"
645+
fi
632646
fi
633647

634648
log "batch-gateway installed."

examples/deploy-demo/deploy-rhoai.md

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,11 @@ Batch-route has no authorization — model-level authz is enforced downstream wh
5757

5858
| Mode | Command |
5959
|------|---------|
60-
| Local chart (default) | `bash examples/deploy-demo/deploy-rhoai.sh install` |
61-
| Specific commit | `BATCH_DEV_VERSION=1f925ff bash examples/deploy-demo/deploy-rhoai.sh install` |
62-
| Released OCI chart | `BATCH_RELEASE_VERSION=v0.1.0 bash examples/deploy-demo/deploy-rhoai.sh install` |
63-
| Specific batch-gateway images | `BATCH_IMAGE_TAG=rhoai-3.5-ea.2` <br> `BATCH_APISERVER_REPO=quay.io/rhoai/odh-llm-d-batch-gateway-apiserver-rhel9` <br> `BATCH_PROCESSOR_REPO=quay.io/rhoai/odh-llm-d-batch-gateway-processor-rhel9` <br> `BATCH_GC_REPO=quay.io/rhoai/odh-llm-d-batch-gateway-gc-rhel9` <br> `bash examples/deploy-demo/deploy-rhoai.sh install` |
60+
| OCI chart v0.2.0 + RHOAI images (default) | `bash examples/deploy-demo/deploy-rhoai.sh install` |
61+
| Different OCI chart version | `BATCH_RELEASE_VERSION=v0.3.0 bash examples/deploy-demo/deploy-rhoai.sh install` |
62+
| Specific commit (dev chart) | `BATCH_DEV_VERSION=1f925ff bash examples/deploy-demo/deploy-rhoai.sh install` |
63+
| Local chart | `BATCH_DEV_VERSION=local bash examples/deploy-demo/deploy-rhoai.sh install` |
64+
| Custom batch-gateway images | `BATCH_IMAGE_TAG=my-tag` <br> `BATCH_APISERVER_REPO=my-registry/apiserver` <br> `BATCH_PROCESSOR_REPO=my-registry/processor` <br> `BATCH_GC_REPO=my-registry/gc` <br> `bash examples/deploy-demo/deploy-rhoai.sh install` |
6465

6566
> `BATCH_RELEASE_VERSION` and `BATCH_DEV_VERSION` cannot be used together.
6667
@@ -132,12 +133,12 @@ Use that only on **ephemeral or dedicated** demo clusters. See [issue #309](http
132133
| Variable | Default | Scope | Description |
133134
|----------|---------|-------|-------------|
134135
| `BATCH_HELM_RELEASE` | `batch-gateway` | all | Helm release name |
135-
| `BATCH_RELEASE_VERSION` | | all | Install from released OCI chart (e.g. `v1.0.0`). Cannot be used with `BATCH_DEV_VERSION` |
136-
| `BATCH_DEV_VERSION` | `local` | all | Image tag / commit SHA. `local` uses local chart + `latest` image. Cannot be used with `BATCH_RELEASE_VERSION` |
137-
| `BATCH_IMAGE_TAG` | | all | Override image tag for all components. Takes precedence over `BATCH_RELEASE_VERSION` / `BATCH_DEV_VERSION` derived tags |
138-
| `BATCH_APISERVER_REPO` | | all | Override apiserver image repository |
139-
| `BATCH_PROCESSOR_REPO` | | all | Override processor image repository |
140-
| `BATCH_GC_REPO` | | all | Override gc image repository |
136+
| `BATCH_RELEASE_VERSION` | `v0.2.0` | all | OCI chart version. Cannot be used with `BATCH_DEV_VERSION` |
137+
| `BATCH_DEV_VERSION` | | all | Commit SHA for dev chart. Overrides `BATCH_RELEASE_VERSION`. `local` uses local chart |
138+
| `BATCH_IMAGE_TAG` | `rhoai-3.5-ea.2` | all | Image tag for all components. Takes precedence over version-derived tags |
139+
| `BATCH_APISERVER_REPO` | `quay.io/rhoai/odh-llm-d-batch-gateway-apiserver-rhel9` | all | Apiserver image repository |
140+
| `BATCH_PROCESSOR_REPO` | `quay.io/rhoai/odh-llm-d-batch-gateway-processor-rhel9` | all | Processor image repository |
141+
| `BATCH_GC_REPO` | `quay.io/rhoai/odh-llm-d-batch-gateway-gc-rhel9` | all | GC image repository |
141142
| `BATCH_DB_TYPE` | `postgresql` | all | Database backend: `postgresql` or `redis` |
142143
| `BATCH_STORAGE_TYPE` | `s3` | all | File storage: `fs` or `s3` |
143144
| `DEMO_TLS_INSECURE_SKIP_VERIFY` | `1` | all | Disables TLS certificate verification for processor → model gateway and Istio Gateway → batch apiserver (**demo/lab only**, [CWE-295](https://cwe.mitre.org/data/definitions/295.html)). Default `1` since demo scripts use self-signed certs. Set to `0` if you have trusted CA certs. |

examples/deploy-demo/deploy-rhoai.sh

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,14 @@ set -euo pipefail
2121
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
2222
REPO_ROOT="$(cd "${SCRIPT_DIR}/../.." && pwd)"
2323

24+
# RHOAI defaults: upstream OCI chart v0.2.0 with RHOAI container images.
25+
# Set before sourcing common.sh so its validation picks them up.
26+
BATCH_RELEASE_VERSION="${BATCH_RELEASE_VERSION:-v0.2.0}"
27+
BATCH_IMAGE_TAG="${BATCH_IMAGE_TAG:-rhoai-3.5-ea.2}"
28+
BATCH_APISERVER_REPO="${BATCH_APISERVER_REPO:-quay.io/rhoai/odh-llm-d-batch-gateway-apiserver-rhel9}"
29+
BATCH_PROCESSOR_REPO="${BATCH_PROCESSOR_REPO:-quay.io/rhoai/odh-llm-d-batch-gateway-processor-rhel9}"
30+
BATCH_GC_REPO="${BATCH_GC_REPO:-quay.io/rhoai/odh-llm-d-batch-gateway-gc-rhel9}"
31+
2432
source "${SCRIPT_DIR}/common.sh"
2533

2634
# ── Configuration ────────────────────────────────────────────────────────────
@@ -1576,12 +1584,12 @@ usage() {
15761584
echo " MODEL_NAME Model name for simulator (default: facebook/opt-125m)"
15771585
echo " MODEL_REPLICAS Number of replicas (default: 1)"
15781586
echo " SIM_IMAGE Simulator image (default: ghcr.io/llm-d/llm-d-inference-sim:v0.7.1)"
1579-
echo " BATCH_IMAGE_TAG Batch gateway image tag (default: from values.yaml)"
1580-
echo " BATCH_APISERVER_REPO Apiserver image repo (default: from values.yaml)"
1581-
echo " BATCH_PROCESSOR_REPO Processor image repo (default: from values.yaml)"
1582-
echo " BATCH_GC_REPO GC image repo (default: from values.yaml)"
1583-
echo " BATCH_DEV_VERSION Batch gateway commit SHA for dev chart (default: local)"
1584-
echo " BATCH_RELEASE_VERSION Install released OCI chart (e.g. v1.0.0)"
1587+
echo " BATCH_RELEASE_VERSION OCI chart version (default: v0.2.0)"
1588+
echo " BATCH_IMAGE_TAG Batch gateway image tag (default: rhoai-3.5-ea.2)"
1589+
echo " BATCH_APISERVER_REPO Apiserver image repo (default: quay.io/rhoai/odh-llm-d-batch-gateway-apiserver-rhel9)"
1590+
echo " BATCH_PROCESSOR_REPO Processor image repo (default: quay.io/rhoai/odh-llm-d-batch-gateway-processor-rhel9)"
1591+
echo " BATCH_GC_REPO GC image repo (default: quay.io/rhoai/odh-llm-d-batch-gateway-gc-rhel9)"
1592+
echo " BATCH_DEV_VERSION Batch gateway commit SHA for dev chart (overrides BATCH_RELEASE_VERSION)"
15851593
echo " BATCH_DB_TYPE Database: postgresql or redis (default: postgresql)"
15861594
echo " BATCH_STORAGE_TYPE File storage: fs or s3 (default: s3)"
15871595
echo " ENABLE_FLOW_CONTROL Enable GIE flow control (default: true)"

0 commit comments

Comments
 (0)