Skip to content

Commit 4b370c8

Browse files
committed
Merge remote-tracking branch 'upstream/main' into rhoai-3.5
2 parents 4d0f3b5 + 7bbc02f commit 4b370c8

4 files changed

Lines changed: 15 additions & 6 deletions

File tree

Makefile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -453,11 +453,12 @@ PROMETHEUS_RELEASE ?= llmd-kube-prometheus-stack
453453

454454
## test-e2e: Run E2E tests against a live API server (requires TEST_BASE_URL or dev-deploy NodePort services)
455455
## Use TEST_RUN to filter tests, e.g.: make test-e2e TEST_RUN=TestE2E/Batches/Cancel/InProgress
456+
## Use TEST_OUTPUT to save JSON test output to a file (adds -json flag), e.g.: make test-e2e TEST_OUTPUT=results.json
456457
test-e2e:
457458
@echo "Running E2E tests..."
458459
@OUT=$$(mktemp); \
459460
echo "Processor observability endpoint: auto-resolved by the e2e test helpers"; \
460-
cd test/e2e && $(GO) test -v -count=1 -timeout=20m $(if $(TEST_RUN),-run $(TEST_RUN)) ./... 2>&1 | tee $$OUT; \
461+
cd test/e2e && $(GO) test -v $(if $(TEST_OUTPUT),-json) -count=1 -timeout=20m $(if $(TEST_RUN),-run $(TEST_RUN)) ./... 2>&1 | tee $$OUT; \
461462
TEST_EXIT=$${PIPESTATUS[0]}; \
462463
PASS_COUNT=$$(grep -- '--- PASS:' $$OUT 2>/dev/null | wc -l | tr -d ' '); \
463464
FAIL_COUNT=$$(grep -- '--- FAIL:' $$OUT 2>/dev/null | wc -l | tr -d ' '); \
@@ -473,5 +474,6 @@ test-e2e:
473474
else \
474475
echo "❌ E2E tests failed with exit code $$TEST_EXIT"; \
475476
fi; \
477+
if [ -n "$(TEST_OUTPUT)" ]; then cp $$OUT "$(TEST_OUTPUT)"; fi; \
476478
rm -f $$OUT; \
477479
exit $$TEST_EXIT

docs/guides/deploy-k8s.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -856,7 +856,8 @@ kubectl rollout status statefulset/postgresql -n ${BATCH_NS} --timeout=120s
856856
# Install MinIO (S3-compatible object storage for batch files)
857857
MINIO_USER=<your-minio-user>
858858
MINIO_PASSWORD=<your-minio-password>
859-
MINIO_BUCKET=batch-gateway
859+
MINIO_BUCKET=llm-d-batch-gateway
860+
MINIO_REGION=us-east-1
860861

861862
kubectl apply -f - <<EOF
862863
apiVersion: apps/v1
@@ -964,7 +965,8 @@ helm upgrade --install batch-gateway ./charts/batch-gateway \
964965
--set "global.dbClient.type=postgresql" \
965966
--set "global.fileClient.type=s3" \
966967
--set "global.fileClient.s3.endpoint=http://minio.${BATCH_NS}.svc.cluster.local:9000" \
967-
--set "global.fileClient.s3.region=us-east-1" \
968+
--set "global.fileClient.s3.region=${MINIO_REGION}" \
969+
--set "global.fileClient.s3.bucket=${MINIO_BUCKET}" \
968970
--set "global.fileClient.s3.accessKeyId=${MINIO_USER}" \
969971
--set "global.fileClient.s3.prefix=${MINIO_BUCKET}" \
970972
--set "global.fileClient.s3.usePathStyle=true" \

examples/deploy-demo/common.sh

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,8 @@ DEMO_TLS_INSECURE_SKIP_VERIFY="${DEMO_TLS_INSECURE_SKIP_VERIFY:-1}"
8181
BATCH_MINIO_RELEASE="${BATCH_MINIO_RELEASE:-minio}"
8282
MINIO_ROOT_USER="${MINIO_ROOT_USER:-minioadmin}"
8383
MINIO_ROOT_PASSWORD="${MINIO_ROOT_PASSWORD:-minioadmin}"
84-
MINIO_BUCKET="${MINIO_BUCKET:-batch-gateway}"
84+
MINIO_BUCKET="${MINIO_BUCKET:-llm-d-batch-gateway}"
85+
MINIO_REGION="${MINIO_REGION:-us-east-1}"
8586
# Image overrides. When set, these take precedence over defaults derived from
8687
# BATCH_RELEASE_VERSION / BATCH_DEV_VERSION. Leave unset to use chart defaults.
8788
# Example (upstream):
@@ -619,7 +620,8 @@ do_deploy_batch_gateway_helm() {
619620
local minio_endpoint="http://${BATCH_MINIO_RELEASE}.${BATCH_NAMESPACE}.svc.cluster.local:9000"
620621
helm_args+=(
621622
--set "global.fileClient.s3.endpoint=${minio_endpoint}"
622-
--set "global.fileClient.s3.region=us-east-1"
623+
--set "global.fileClient.s3.region=${MINIO_REGION}"
624+
--set "global.fileClient.s3.bucket=${MINIO_BUCKET}"
623625
--set "global.fileClient.s3.accessKeyId=${MINIO_ROOT_USER}"
624626
--set "global.fileClient.s3.prefix=${MINIO_BUCKET}"
625627
--set "global.fileClient.s3.usePathStyle=true"
@@ -776,7 +778,8 @@ do_deploy_batch_gateway_dsc() {
776778
if [ "${BATCH_STORAGE_TYPE}" = "s3" ]; then
777779
local minio_endpoint="http://${BATCH_MINIO_RELEASE}.${BATCH_NAMESPACE}.svc.cluster.local:9000"
778780
file_storage_yaml=" s3:
779-
region: us-east-1
781+
region: ${MINIO_REGION}
782+
bucket: ${MINIO_BUCKET}
780783
endpoint: ${minio_endpoint}
781784
accessKeyId: ${MINIO_ROOT_USER}
782785
prefix: ${MINIO_BUCKET}

examples/deploy-demo/deploy-k8s.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,8 @@ Use that only on **ephemeral or dedicated** demo clusters. See [issue #309](http
124124
| `BATCH_GC_REPO` || Override gc image repository |
125125
| `BATCH_DB_TYPE` | `postgresql` | Database backend: `postgresql` or `redis` |
126126
| `BATCH_STORAGE_TYPE` | `s3` | File storage: `fs` or `s3` |
127+
| `MINIO_BUCKET` | `llm-d-batch-gateway` | MinIO bucket name (also used as the S3 `bucket` and `prefix` config values) |
128+
| `MINIO_REGION` | `us-east-1` | S3 region for MinIO |
127129
| `DEMO_TLS_INSECURE_SKIP_VERIFY` | `1` | Disables TLS certificate verification for processor → model gateway and Istio Gateway → batch apiserver (**demo/lab only**, [CWE-295](https://cwe.mitre.org/data/definitions/295.html)). Default `1` since demo scripts use self-signed certs. Set to `0` if you have trusted CA certs. |
128130
| `BATCH_NAMESPACE` | `batch-api` | Namespace for batch-gateway |
129131
| `LLM_NAMESPACE` | `llm` | Namespace for model serving |

0 commit comments

Comments
 (0)