Skip to content

Commit 0d31b40

Browse files
authored
update: add wva and spark into exmpale for xKS (opendatahub-io#57)
- correct docs - fix MWC annotation namespace value Signed-off-by: Wen Zhou <wenzhou@redhat.com>
1 parent 8a22350 commit 0d31b40

10 files changed

Lines changed: 40 additions & 19 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ To add a new dependency, follow the [Contributing](CONTRIBUTING.md#add-a-new-dep
141141

142142
### Prerequisites
143143

144-
- OpenShift cluster (version 4.19 or later)
144+
- OpenShift cluster (version 4.19.9 or later)
145145
- `kubectl` or `oc` CLI installed
146146
- Cluster admin permissions
147147
- Kustomize v5 or later (optional - `kubectl` has built-in Kustomize support)

charts/odh-rhoai/Chart.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,3 +9,4 @@ keywords:
99
- rhoai
1010
- odh
1111
- ai
12+
- rhaii

charts/odh-rhoai/README.md

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,17 @@ This chart provides a flexible way to install the operators and configurations r
1313

1414
## Quick Start
1515

16+
> [!NOTE]
17+
> All commands below assume you are in the repository root directory.
18+
1619
```bash
1720
# Install dependencies with default settings. We need to install the dependencies before the operator is installed.
18-
helm upgrade --install rhoai ./chart -n opendatahub-gitops --create-namespace
21+
# Set OPERATOR_TYPE to: odh | rhoai
22+
export OPERATOR_TYPE=${OPERATOR_TYPE:-odh}
23+
helm upgrade --install ${OPERATOR_TYPE} ./charts/odh-rhoai -n ${OPERATOR_TYPE}-gitops --create-namespace --set operator.type=${OPERATOR_TYPE}
1924

2025
# Wait for CRDs to be created, then run again to create CRs
21-
helm upgrade --install rhoai ./chart -n opendatahub-gitops
26+
helm upgrade --install ${OPERATOR_TYPE} ./charts/odh-rhoai -n ${OPERATOR_TYPE}-gitops --create-namespace --set operator.type=${OPERATOR_TYPE}
2227
```
2328

2429
## Installation Flow
@@ -27,7 +32,7 @@ Due to CRD dependencies (operators create CRDs that are needed for CR resources)
2732

2833
```bash
2934
for i in {1..5}; do
30-
helm upgrade --install rhoai ./chart -n opendatahub-gitops --create-namespace
35+
helm upgrade --install ${OPERATOR_TYPE} ./charts/odh-rhoai -n ${OPERATOR_TYPE}-gitops --create-namespace --set operator.type=${OPERATOR_TYPE}
3136
sleep 60
3237
done
3338
```

charts/odh-rhoai/values.schema.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,9 @@
134134
},
135135
"llamastackoperator": {
136136
"$ref": "#/definitions/component"
137+
},
138+
"sparkoperator": {
139+
"$ref": "#/definitions/component"
137140
}
138141
},
139142
"additionalProperties": false

charts/rhaii-helm-chart/scripts/update-bundle.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ CHART_DIR="$(cd "${SCRIPT_DIR}/.." && pwd)"
2929
NAMESPACE="redhat-ods-operator"
3030

3131
# helmtemplate-generator Go module
32-
HELMTEMPLATE_GENERATOR_PKG="github.com/davidebianchi/helmtemplate-generator@64f313ee820134546c77d04c69f5a6cb86f4c737"
32+
HELMTEMPLATE_GENERATOR_PKG="github.com/davidebianchi/helmtemplate-generator@7d76ac29fe5f7cdc6a6c9b953f8dc715ee348bef"
3333

3434
# Cloud mappings: <cloud_name> <kustomize_subdir> <output_subdir>
3535
CLOUD_TARGETS=(

charts/rhaii-helm-chart/templates/webhooks/mutatingwebhookconfiguration-rhods-operator-mutating-webhook-configuration.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ apiVersion: admissionregistration.k8s.io/v1
33
kind: MutatingWebhookConfiguration
44
metadata:
55
annotations:
6-
cert-manager.io/inject-ca-from: redhat-ods-operator/opendatahub-operator-webhook-cert
6+
cert-manager.io/inject-ca-from: {{ .Values.rhaiOperator.namespace }}/opendatahub-operator-webhook-cert
77
name: rhods-operator-mutating-webhook-configuration
88
namespace: {{ .Values.rhaiOperator.namespace }}
99
webhooks:

charts/rhaii-helm-chart/test/snapshots/with-custom-namespace.snap.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2570,7 +2570,7 @@ apiVersion: admissionregistration.k8s.io/v1
25702570
kind: MutatingWebhookConfiguration
25712571
metadata:
25722572
annotations:
2573-
cert-manager.io/inject-ca-from: redhat-ods-operator/opendatahub-operator-webhook-cert
2573+
cert-manager.io/inject-ca-from: rhai-operator/opendatahub-operator-webhook-cert
25742574
name: rhods-operator-mutating-webhook-configuration
25752575
namespace: rhai-operator
25762576
webhooks:

docs/examples/values-inference-only.yaml

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@
1010
# - RHCL / Kuadrant (API management / Authorino)
1111
#
1212
# Usage:
13-
# helm upgrade --install rhoai ./charts/odh-rhoai \
13+
# helm upgrade --install rhaii ./charts/odh-rhoai \
1414
# -f docs/examples/values-inference-only.yaml \
15-
# -n opendatahub-gitops --create-namespace
15+
# -n rhaii-gitops --create-namespace
1616
# =============================================================================
1717

1818
# -- Set skipCrdCheck to true for ArgoCD (see docs/inference-only-stack.md)
@@ -21,7 +21,7 @@
2121
# -- Operator configuration
2222
operator:
2323
enabled: true
24-
type: rhoai # Change to "odh" for Open Data Hub
24+
type: rhoai
2525

2626
# -- Disable monitoring (not needed for inference-only)
2727
services:
@@ -51,6 +51,8 @@ components:
5151
managementState: Removed
5252
nim:
5353
managementState: Removed
54+
wva:
55+
managementState: Removed
5456

5557
# -- Disable all non-inference components
5658
aipipelines:
@@ -100,3 +102,7 @@ components:
100102
llamastackoperator:
101103
dsc:
102104
managementState: Removed
105+
106+
sparkoperator:
107+
dsc:
108+
managementState: Removed

docs/inference-only-stack.md

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ The stack installs a minimal set of dependency operators required by KServe:
2828

2929
## Prerequisites
3030

31-
- OpenShift cluster (version 4.19 or later)
31+
- OpenShift cluster (version 4.19.9 or later)
3232
- `kubectl` or `oc` CLI installed
3333
- Cluster admin permissions
3434
- Helm v4
@@ -43,7 +43,7 @@ The values override configures the chart to install:
4343
4. **DataScienceCluster** (DSC) with only KServe set to `Managed`
4444

4545
All other components (AI Pipelines, Dashboard, Feast, Kueue, Model Registry, Ray, Trainer, Training Operator, TrustyAI,
46-
Workbenches, MLflow, LlamaStack) are set to `Removed`.
46+
Workbenches, MLflow, LlamaStack, Spark Operator) are set to `Removed`.
4747

4848
## Values Override
4949

@@ -86,6 +86,8 @@ components:
8686
managementState: Removed
8787
nim:
8888
managementState: Removed
89+
wva:
90+
managementState: Removed
8991

9092
# -- Disable all non-inference components
9193
aipipelines:
@@ -135,6 +137,10 @@ components:
135137
llamastackoperator:
136138
dsc:
137139
managementState: Removed
140+
141+
sparkoperator:
142+
dsc:
143+
managementState: Removed
138144
```
139145
140146
> [!NOTE]
@@ -157,9 +163,9 @@ The first run installs the OLM subscriptions (Namespace, OperatorGroup, Subscrip
157163
CRDs do not exist yet.
158164

159165
```bash
160-
helm upgrade --install rhoai ./charts/odh-rhoai \
166+
helm upgrade --install rhaii ./charts/odh-rhoai \
161167
-f docs/examples/values-inference-only.yaml \
162-
-n opendatahub-gitops --create-namespace
168+
-n rhaii-gitops --create-namespace
163169
```
164170

165171
### 3. Wait for CRDs
@@ -189,9 +195,9 @@ Now that CRDs exist, the second run creates the CR resources (DSCInitialization,
189195
LeaderWorkerSetOperator, etc.):
190196

191197
```bash
192-
helm upgrade --install rhoai ./charts/odh-rhoai \
198+
helm upgrade --install rhaii ./charts/odh-rhoai \
193199
-f docs/examples/values-inference-only.yaml \
194-
-n opendatahub-gitops
200+
-n rhaii-gitops
195201
```
196202

197203
### 5. Enable Authorino TLS (post-install)
@@ -278,9 +284,9 @@ install:
278284
2. Run `helm upgrade` again. CRs are skipped until their CRDs exist:
279285

280286
```bash
281-
helm upgrade --install rhoai ./charts/odh-rhoai \
287+
helm upgrade --install rhaii ./charts/odh-rhoai \
282288
-f docs/examples/values-inference-only.yaml \
283-
-n opendatahub-gitops
289+
-n rhaii-gitops
284290
```
285291

286292
### Authorino TLS issues

scripts/extract-olm-bundle.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ trap 'echo "ERROR: Script failed at line $LINENO" >&2; exit 1' ERR
3636
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
3737

3838
# helmtemplate-generator Go module (used via go run)
39-
HELMTEMPLATE_GENERATOR_PKG="github.com/davidebianchi/helmtemplate-generator@3bc347fc1affd320b7829e64d262c9c5c6f4c40f"
39+
HELMTEMPLATE_GENERATOR_PKG="github.com/davidebianchi/helmtemplate-generator@7d76ac29fe5f7cdc6a6c9b953f8dc715ee348bef"
4040

4141
# OLM extractor image
4242
OLM_EXTRACTOR_IMAGE="quay.io/lburgazzoli/olm-extractor:main"

0 commit comments

Comments
 (0)