Skip to content

Commit b697019

Browse files
committed
fix: update gateway defaults
1 parent 607d1fa commit b697019

7 files changed

Lines changed: 19 additions & 15 deletions

File tree

charts/rhai-on-openshift-chart/api-docs.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ A Helm chart for installing ODH/RHOAI dependencies and component configurations
1818
| components.feastoperator.dependencies | object | `{}` | Dependencies required by Feast Operator |
1919
| components.feastoperator.dsc | object | `{"managementState":null}` | DSC configuration for Feast Operator |
2020
| components.feastoperator.dsc.managementState | string | `nil` | Management state for Feast Operator. Null uses profile default. |
21-
| components.kserve | object | `{"dependencies":{"certManager":true,"customMetricsAutoscaler":false,"jobSet":null,"leaderWorkerSet":true,"rhcl":true},"dsc":{"managementState":null,"modelsAsService":{"managementState":null},"nim":{"managementState":null},"rawDeploymentServiceConfig":"Headless","wva":{"managementState":null}},"gateway":{"create":"auto","labels":{"istio.io/rev":"openshift-gateway"},"name":"openshift-ai-inference","namespace":"openshift-ingress","spec":{"gatewayClassName":"openshift-ai-inference","listeners":[{"allowedRoutes":{"namespaces":{"from":"All"}},"name":"https","port":443,"protocol":"HTTPS"}]}},"gatewayClass":{"create":"auto","name":"openshift-ai-inference","spec":{"controllerName":"openshift.io/gateway-controller/v1"}},"modelsAsService":{"gateway":{"annotations":{"opendatahub.io/managed":"false","security.opendatahub.io/authorino-tls-bootstrap":"true"},"create":false,"name":"maas-default-gateway","namespace":"openshift-ingress","spec":{"gatewayClassName":"maas-gateway-class","listeners":[{"allowedRoutes":{"namespaces":{"from":"All"}},"name":"https","port":443,"protocol":"HTTPS"}]}},"gatewayClass":{"create":false,"name":"maas-gateway-class","spec":{"controllerName":"openshift.io/gateway-controller/v1"}}}}` | KServe model serving component |
21+
| components.kserve | object | `{"dependencies":{"certManager":true,"customMetricsAutoscaler":false,"jobSet":null,"leaderWorkerSet":true,"rhcl":true},"dsc":{"managementState":null,"modelsAsService":{"managementState":null},"nim":{"managementState":null},"rawDeploymentServiceConfig":"Headless","wva":{"managementState":null}},"gateway":{"create":"auto","labels":{"istio.io/rev":"openshift-gateway"},"name":"openshift-ai-inference","namespace":"openshift-ingress","spec":{"gatewayClassName":"openshift-ai-inference","listeners":[{"allowedRoutes":{"namespaces":{"from":"Same"}},"name":"https","port":443,"protocol":"HTTPS"}]}},"gatewayClass":{"create":"auto","name":"openshift-ai-inference","spec":{"controllerName":"openshift.io/gateway-controller/v1"}},"modelsAsService":{"gateway":{"annotations":{"opendatahub.io/managed":"false","security.opendatahub.io/authorino-tls-bootstrap":"true"},"create":false,"name":"maas-default-gateway","namespace":"openshift-ingress","spec":{"gatewayClassName":"maas-gateway-class","listeners":[{"allowedRoutes":{"namespaces":{"from":"Same"}},"name":"https","port":443,"protocol":"HTTPS"}]}},"gatewayClass":{"create":false,"name":"maas-gateway-class","spec":{"controllerName":"openshift.io/gateway-controller/v1"}}}}` | KServe model serving component |
2222
| components.kserve.dependencies | object | `{"certManager":true,"customMetricsAutoscaler":false,"jobSet":null,"leaderWorkerSet":true,"rhcl":true}` | Dependencies required by KServe (set to false to disable) |
2323
| components.kserve.dependencies.jobSet | string | `nil` | JobSet dependency. Null uses profile default (true for default, false for rhaii). |
2424
| components.kserve.dsc | object | `{"managementState":null,"modelsAsService":{"managementState":null},"nim":{"managementState":null},"rawDeploymentServiceConfig":"Headless","wva":{"managementState":null}}` | DSC configuration for KServe |
@@ -30,13 +30,13 @@ A Helm chart for installing ODH/RHOAI dependencies and component configurations
3030
| components.kserve.dsc.rawDeploymentServiceConfig | string | `"Headless"` | Raw deployment service config for KServe (Headless or Headed) |
3131
| components.kserve.dsc.wva | object | `{"managementState":null}` | Note: When run on Openshift, and set to Managed ensure Custom Metrics Autoscaler (CMA) or Prometheus Adapter is installed |
3232
| components.kserve.dsc.wva.managementState | string | `nil` | Management state for workload-variant-autoscaler. Null uses profile default. |
33-
| components.kserve.gateway | object | `{"create":"auto","labels":{"istio.io/rev":"openshift-gateway"},"name":"openshift-ai-inference","namespace":"openshift-ingress","spec":{"gatewayClassName":"openshift-ai-inference","listeners":[{"allowedRoutes":{"namespaces":{"from":"All"}},"name":"https","port":443,"protocol":"HTTPS"}]}}` | Gateway configuration for KServe inference. |
33+
| components.kserve.gateway | object | `{"create":"auto","labels":{"istio.io/rev":"openshift-gateway"},"name":"openshift-ai-inference","namespace":"openshift-ingress","spec":{"gatewayClassName":"openshift-ai-inference","listeners":[{"allowedRoutes":{"namespaces":{"from":"Same"}},"name":"https","port":443,"protocol":"HTTPS"}]}}` | Gateway configuration for KServe inference. |
3434
| components.kserve.gateway.create | string | `"auto"` | Flag to create the Gateway (auto, true, false). If auto, it will be created if KServe is Managed. |
3535
| components.kserve.gatewayClass | object | `{"create":"auto","name":"openshift-ai-inference","spec":{"controllerName":"openshift.io/gateway-controller/v1"}}` | GatewayClass configuration for KServe inference |
3636
| components.kserve.gatewayClass.create | string | `"auto"` | Create the GatewayClass: auto (if KServe is Managed), true (always), false (never) |
3737
| components.kserve.gatewayClass.name | string | `"openshift-ai-inference"` | GatewayClass name |
3838
| components.kserve.gatewayClass.spec | object | `{"controllerName":"openshift.io/gateway-controller/v1"}` | GatewayClass spec |
39-
| components.kserve.modelsAsService.gateway | object | `{"annotations":{"opendatahub.io/managed":"false","security.opendatahub.io/authorino-tls-bootstrap":"true"},"create":false,"name":"maas-default-gateway","namespace":"openshift-ingress","spec":{"gatewayClassName":"maas-gateway-class","listeners":[{"allowedRoutes":{"namespaces":{"from":"All"}},"name":"https","port":443,"protocol":"HTTPS"}]}}` | Gateway configuration for the LLMInferenceService. |
39+
| components.kserve.modelsAsService.gateway | object | `{"annotations":{"opendatahub.io/managed":"false","security.opendatahub.io/authorino-tls-bootstrap":"true"},"create":false,"name":"maas-default-gateway","namespace":"openshift-ingress","spec":{"gatewayClassName":"maas-gateway-class","listeners":[{"allowedRoutes":{"namespaces":{"from":"Same"}},"name":"https","port":443,"protocol":"HTTPS"}]}}` | Gateway configuration for the LLMInferenceService. |
4040
| components.kserve.modelsAsService.gateway.create | bool | `false` | Flag to create the Gateway (auto, true, false). If auto, it will be created if Models as Service is Managed. |
4141
| components.kserve.modelsAsService.gatewayClass | object | `{"create":false,"name":"maas-gateway-class","spec":{"controllerName":"openshift.io/gateway-controller/v1"}}` | Gateway Class configuration for the LLMInferenceService. |
4242
| components.kserve.modelsAsService.gatewayClass.create | bool | `false` | Flag to create the Gateway Class (auto, true, false). If auto, it will be created if Models as Service is Managed. |

charts/rhai-on-openshift-chart/test/snapshots/all-components-managed.snap.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ spec:
184184
listeners:
185185
- allowedRoutes:
186186
namespaces:
187-
from: All
187+
from: Same
188188
name: https
189189
port: 443
190190
protocol: HTTPS
@@ -206,7 +206,7 @@ spec:
206206
listeners:
207207
- allowedRoutes:
208208
namespaces:
209-
from: All
209+
from: Same
210210
name: https
211211
port: 443
212212
protocol: HTTPS

charts/rhai-on-openshift-chart/test/snapshots/enable-llm-d-wva.snap.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ spec:
139139
listeners:
140140
- allowedRoutes:
141141
namespaces:
142-
from: All
142+
from: Same
143143
name: https
144144
port: 443
145145
protocol: HTTPS

charts/rhai-on-openshift-chart/test/snapshots/inference-only.snap.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ spec:
121121
listeners:
122122
- allowedRoutes:
123123
namespaces:
124-
from: All
124+
from: Same
125125
name: https
126126
port: 443
127127
protocol: HTTPS

charts/rhai-on-openshift-chart/test/snapshots/profile-with-customization.snap.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ spec:
130130
listeners:
131131
- allowedRoutes:
132132
namespaces:
133-
from: All
133+
from: Same
134134
name: https
135135
port: 443
136136
protocol: HTTPS

charts/rhai-on-openshift-chart/test/snapshots/with-rhcl-config.snap.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ spec:
130130
listeners:
131131
- allowedRoutes:
132132
namespaces:
133-
from: All
133+
from: Same
134134
name: https
135135
port: 443
136136
protocol: HTTPS

charts/rhai-on-openshift-chart/values.yaml

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -176,8 +176,11 @@ components:
176176
protocol: HTTPS
177177
allowedRoutes:
178178
namespaces:
179-
from: All
180-
# The following is an example of how to restrict the namespaces to the interested ones.
179+
from: Same
180+
# Example for All (any namespace can attach routes):
181+
# from: All
182+
#
183+
# Example for Selector (only namespaces matching labels):
181184
# from: Selector
182185
# selector:
183186
# matchExpressions:
@@ -186,7 +189,6 @@ components:
186189
# values:
187190
# - llm-namespace1
188191
# - llm-namespace2
189-
# - ...
190192
# Uncomment this to enable TLS termination for the Gateway.
191193
# tls:
192194
# certificateRefs:
@@ -220,16 +222,18 @@ components:
220222
protocol: HTTPS
221223
allowedRoutes:
222224
namespaces:
223-
from: All
224-
# The following is an example of how to restrict the namespaces to the interested ones.
225+
from: Same
226+
# Example for All (any namespace can attach routes):
227+
# from: All
228+
#
229+
# Example for Selector (only namespaces matching labels):
225230
# from: Selector
226231
# selector:
227232
# matchExpressions:
228233
# - key: kubernetes.io/metadata.name
229234
# operator: In
230235
# values:
231236
# - openshift-ingress
232-
# - ...
233237
# tls: # Uncomment this to enable TLS termination for the Gateway.
234238
# certificateRefs:
235239
# - group: ''

0 commit comments

Comments
 (0)