Skip to content

Commit 2bf488b

Browse files
committed
fix: ignore dev transitive build scripts for strictDepBuilds CI
List eslint-plugin-n8n-nodes-base and unrs-resolver in ignoredBuiltDependencies so pnpm install --frozen-lockfile passes under strictDepBuilds after adding @n8n/node-cli.
1 parent f09bd34 commit 2bf488b

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

SECURITY.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ This repository uses defenses against npm supply-chain worms such as **Mini Shai
99
- **pnpm only**`packageManager`, `engines.pnpm`, and `pnpm-lock.yaml` enforce a single package manager. Enable Corepack so `npm install` / `yarn install` are rejected in this repo (see below). We do **not** use a `preinstall` script: that would run when end users install the published node via npm in n8n.
1010
- **Frozen lockfile**`pnpm-lock.yaml` is committed; CI uses `pnpm install --frozen-lockfile`.
1111
- **pnpm workspace config** — supply-chain settings live in `pnpm-workspace.yaml` (pnpm 10+ ignores `package.json``pnpm`).
12-
- **Blocked install scripts** — only packages in `pnpm-workspace.yaml``onlyBuiltDependencies` may run lifecycle scripts (currently `isolated-vm` for dev tooling). `strictDepBuilds: true` fails on unreviewed scripts.
12+
- **Blocked install scripts** — only packages in `pnpm-workspace.yaml``onlyBuiltDependencies` may run lifecycle scripts (currently `isolated-vm` for dev tooling). Other packages with scripts are listed in `ignoredBuiltDependencies` (e.g. `unrs-resolver`, `eslint-plugin-n8n-nodes-base`). `strictDepBuilds: true` fails on unreviewed scripts.
1313
- **Blocklist scan**`pnpm run audit:supply-chain` checks the lockfile against `security/compromised-packages.json` and validates pnpm config.
1414
- **Delayed updates**`minimumReleaseAge` (24h, strict) reduces exposure to freshly published malicious versions.
1515
- **No exotic transitive deps**`blockExoticSubdeps` blocks git/tarball transitive resolutions.

pnpm-workspace.yaml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,10 @@ overrides:
1212
onlyBuiltDependencies:
1313
- isolated-vm
1414

15-
ignoredBuiltDependencies: []
15+
# Dev-only transitive packages with install scripts we intentionally skip (prebuilt or optional native).
16+
ignoredBuiltDependencies:
17+
- eslint-plugin-n8n-nodes-base
18+
- unrs-resolver
1619

1720
# Wait 24h before installing newly published versions.
1821
minimumReleaseAge: 1440

0 commit comments

Comments
 (0)