Skip to content

Commit b5d10e5

Browse files
committed
hexview: drop 'override' on comment() for QHexView <v5.1.0 compat
QHexDelegate::comment() virtual was added to QHexView after the v5.1.0 tag. Building against v5.1.0 fails with: error: 'QString FlagsDelegate::comment(...)' marked 'override', but does not override Remove the override specifier so the code compiles against released QHexView versions. The comment() feature will be a no-op until QHexView ships a tagged release with the virtual.
1 parent c8bb6c8 commit b5d10e5

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

src/hexview/flagsdelegate.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ class FlagsDelegate: public QHexDelegate {
1212

1313
public:
1414
QString comment(quint64 offset, quint8 b,
15-
const QHexView* hexview) const override;
15+
const QHexView* hexview) const;
1616
bool renderByte(quint64 offset, quint8 b, QHexCharFormat& outcf,
17-
const QHexView* hexview) const override;
17+
const QHexView* hexview) const;
1818

1919
private:
2020
const RDFlagsBuffer* m_flags{nullptr};

0 commit comments

Comments
 (0)