Changed browser kill process to use SIGTERM. Prepared package.json for 1.2.8 release

andrewbrazzatti · andrewbrazzatti · commit f1fa7d8cb6b4 · 2021-10-28T15:05:12.000+10:30
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -6,7 +6,7 @@ jobs:
     working_directory: ~/repo
     steps:
       - checkout
-      - run: npm install
+      - run: npm install && node_modules/.bin/tsc
       # run tests!
       # - run: npm test
       # # store test results
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@researchdatabox/sails-hook-redbox-pdfgen",
-  "version": "1.2.7",
+  "version": "1.2.8",
   "description": "Adds PDF generation functionality for records to ReDBox",
   "main": "index.js",
   "sails": {
diff --git a/typescript/api/services/PDFService.ts b/typescript/api/services/PDFService.ts
@@ -150,7 +150,7 @@ export module Services {
       } finally {
         // clean up in case browser didn't close properly
         if (browser && browser.process() != null) { 
-          browser.process().kill('SIGINT');
+          browser.process().kill('SIGTERM');
         }
         fs.removeSync(tmpUserDataDir, { recursive: true });
       }

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@researchdatabox/sails-hook-redbox-pdfgen",`
`3`		`- "version": "1.2.7",`
	`3`	`+ "version": "1.2.8",`
`4`	`4`	`"description": "Adds PDF generation functionality for records to ReDBox",`
`5`	`5`	`"main": "index.js",`
`6`	`6`	`"sails": {`
Original file line number	Diff line number	Diff line change
`@@ -150,7 +150,7 @@ export module Services {`
`150`	`150`	`} finally {`
`151`	`151`	`// clean up in case browser didn't close properly`
`152`	`152`	`if (browser && browser.process() != null) {`
`153`		`- browser.process().kill('SIGINT');`
	`153`	`+ browser.process().kill('SIGTERM');`
`154`	`154`	`}`
`155`	`155`	`fs.removeSync(tmpUserDataDir, { recursive: true });`
`156`	`156`	`}`