Skip to content

Llvm test#3

Closed
reddevilmidzy wants to merge 2 commits intomainfrom
llvm-test
Closed

Llvm test#3
reddevilmidzy wants to merge 2 commits intomainfrom
llvm-test

Conversation

@reddevilmidzy
Copy link
Copy Markdown
Owner

@reddevilmidzy reddevilmidzy commented Feb 10, 2026

for llvm test

reddevilmidzy and others added 2 commits February 10, 2026 16:00
@reddevilmidzy @BoxyUwU
mGCA: Validate const literal against expected type
ada819e 
Co-authored-by: Boxy <rust@boxyuwu.dev>
@reddevilmidzy
modify error comment and bless test, delete tests/ui/const-generics/g…
a824429 
…eneric_const_exprs/lit_type_mismatch.rs
reddevilmidzy
reddevilmidzy commented Feb 10, 2026
View reviewed changes
Comment thread compiler/rustc_hir_analysis/src/hir_ty_lowering/mod.rs
Comment thread compiler/rustc_mir_build/src/thir/constant.rs
Comment thread tests/ui/consts/const-eval/array-len-mismatch-type.rs
@@ -0,0 +1,8 @@
//! Regression test for <https://github.com/rust-lang/rust/issues/133966>
Copy link
Copy Markdown
Owner Author

@reddevilmidzy reddevilmidzy Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이게 crashes에 있다가 빠져나온거. 이슈 체크하기.

@reddevilmidzy
Copy link
Copy Markdown
Owner Author

reddevilmidzy commented Feb 10, 2026

아 그리고 -1u32 ,,, 전에 이슈에서 언급한 테스트 추가하기

@reddevilmidzy reddevilmidzy deleted the llvm-test branch February 11, 2026 05:04
rust-cloud-vms Bot pushed a commit that referenced this pull request Mar 24, 2026
@JonathanBrouwer
Rollup merge of rust-lang#153912 - mu001999-contrib:fix-153842, r=pet…
924b911 
…rochenkov

Avoid prematurely choosing a glob import

Fixes rust-lang#153842

Use the following without introducing trait to explain:
```rust
mod a {
    pub use crate::x::y as x; // single import #1
}

mod b {
    pub mod x {
        pub mod y {}
    }
}

use a::x; // single import #2
use b::*; // glob import #3

fn main() {}
```

In current implementation, when `#1` is first resolved, `crate::x` is temporarily taken from glob import `#3` as `crate::b::x`. This happens because `single_import_can_define_name` will see that `#2` cannot define `x` (because it depends on `#1` and `#1` is ignored) and then return `false`. Later, during finalization, `crate::x` in `#1` resolves through single import `#2` instead, which no longer matches the initially cached module `crate::b::x` and triggers the ICE.

I think the resolver should keep this unresolved because `#2` may still define `x` to avoid prematurely choosing a glob import.

r? petrochenkov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@reddevilmidzy