Preserve duplicate WebView asset paths#281
Open
CR29-22-2805 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #280
💸 TL;DR
This PR preserves every original WebView asset path in
webViewAssetMapwhen multiple files have identical contents.Identical assets are still uploaded only once, but each duplicate file path now maps to the shared uploaded URL.
📜 Details
AssetUploaderalready detects WebView assets with matching hashes and sizes and avoids uploading duplicate contents more than once.However, only the path of the unique uploaded asset was added to
webViewAssetMap. Other files with the same contents were classified as duplicates but omitted from the final map.For example, two identical files:
could result in a map containing only one path.
This PR:
webViewAssetMap.newAssets.find(...)duplicate lookup with a signature-basedSet.The asset signature continues to use the asset hash and size, matching the existing duplicate-classification behavior.
🧪 Testing Steps / Validation
Added regression coverage for two WebView assets that have:
The test verifies that:
webViewAssetMap.Validation completed:
git diff --checkFocused test to run:
✅ Checks