KFLUXVNGD-1117 Add normalized_uri to production federation label allowlist by amisstea · Pull Request #13109 · redhat-appstudio/infra-deployments

amisstea · 2026-07-17T16:31:18Z

What

Add normalized_uri to the federation LabelKeep regex in production writeRelabelConfigs
Move cache_status from the "Probes / testing" group into a new "Caching" group alongside normalized_uri

Clusters affected: all production clusters (via production/base/)

Why

The normalized_uri label on caching metrics needs to survive remote-write to RHOBS so it is available for Grafana queries.

Validation

kustomize build --enable-helm passes for affected overlays
Staging PR: KFLUXVNGD-1117 Add normalized_uri to staging federation label allowlist #13086

Risk Assessment

Risk Level: Low
What could go wrong: Unlikely to cause issues — this only appends a new alternative to an existing regex.
Rollback: Revert PR

…wlist The normalized_uri label is needed in RHOBS for Grafana queries on caching HTTP metrics. Also moves cache_status out of the probes/testing group into a new Caching group alongside normalized_uri. Assisted-by: Claude claude-opus-4-6 Signed-off-by: amisstea <amisstea@redhat.com>

github-actions · 2026-07-17T16:31:53Z

Kustomize Render Diff

Comparing 4978c0d0d → bc56cfedf

Component	Environment	Changes
`components/monitoring/prometheus/production/base`	production	+1 -1
`components/monitoring/prometheus/production/kflux-fedora-01`	production	+1 -1
`components/monitoring/prometheus/production/kflux-ocp-p01`	production	+1 -1
`components/monitoring/prometheus/production/kflux-osp-p01`	production	+1 -1
`components/monitoring/prometheus/production/kflux-prd-es01`	production	+1 -1
`components/monitoring/prometheus/production/kflux-prd-rh02`	production	+1 -1
`components/monitoring/prometheus/production/kflux-prd-rh03`	production	+1 -1
`components/monitoring/prometheus/production/kflux-rhel-p01`	production	+1 -1
`components/monitoring/prometheus/production/stone-prd-rh01`	production	+1 -1
`components/monitoring/prometheus/production/stone-prod-p01`	production	+1 -1
`components/monitoring/prometheus/production/stone-prod-p02`	production	+1 -1

Total: 11 components, +11 -11 lines

📋 Full diff available in the workflow summary and as a downloadable artifact.

qodo-for-redhat-appstudio · 2026-07-17T16:32:53Z

PR Summary by Qodo

Allow normalized_uri label in production Prometheus federation allowlist

⚙️ Configuration changes ✨ Enhancement 🕐 10-20 Minutes

AI Description

• Add normalized_uri to the production federation label allowlist for RHOBS Grafana queries.
• Reclassify caching-related labels by grouping cache_status under a new “Caching” section.
• Keep the allowlist documentation/comments aligned with current ownership and tickets.

Diagram

graph TD
  A["writeRelabelConfigs.yaml"] --> B["Label allowlist"] --> C["Prometheus federation"] --> D["RHOBS"] --> E["Grafana"]
  B --> F["Caching labels"]

High-Level Assessment

The following are alternative approaches to this PR:

1. Use recording rules to avoid relying on normalized_uri at query time

➕ Reduces reliance on high-cardinality labels in ad-hoc Grafana queries
➕ Can standardize dashboards against pre-aggregated series
➖ Requires additional rules, rollout, and ownership for rule maintenance
➖ Less flexible for exploratory debugging compared to querying by URI

2. Transform normalized_uri into a lower-cardinality label at ingestion

➕ Controls cardinality more aggressively (e.g., bucketing/templating routes)
➕ May reduce storage/query cost if normalized_uri is still too granular
➖ More complex relabeling logic and higher risk of breaking existing queries
➖ May not meet the debugging needs that motivated normalized_uri

Recommendation: Proceed with the current allowlist change: it’s the smallest, most direct way to unblock RHOBS/Grafana queries for caching HTTP metrics. As a follow-up guardrail, validate label cardinality/series growth after enabling normalized_uri to ensure it stays within acceptable limits.

Files changed (1) +4 / -2

Other (1) +4 / -2

writeRelabelConfigs.yamlAdd normalized_uri to production federation label allowlist +4/-2

Add normalized_uri to production federation label allowlist
• Extends the production federation label allowlist to include 'normalized_uri' so it is preserved into RHOBS for Grafana queries. Reorganizes label grouping by moving 'cache_status' into a new “Caching” section alongside 'normalized_uri' and updates the related comment annotations.
components/monitoring/prometheus/production/base/federation/writeRelabelConfigs.yaml

qodo-for-redhat-appstudio · 2026-07-17T16:34:07Z

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

amisstea · 2026-07-17T16:39:02Z

/rerun

github-actions · 2026-07-17T16:39:14Z

Re-triggered 1 of 1 failed GitHub Actions workflow run(s).

Prow/OpenShift CI E2E checks are not affected — comment /retest to re-trigger those.

codecov · 2026-07-17T16:56:14Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.11%. Comparing base (4978c0d) to head (837b68a).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #13109   +/-   ##
=======================================
  Coverage   57.11%   57.11%           
=======================================
  Files          23       23           
  Lines        1455     1455           
=======================================
  Hits          831      831           
  Misses        548      548           
  Partials       76       76

Flag	Coverage Δ
go	`57.11% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

pacho-rh

/lgtm

openshift-ci · 2026-07-17T17:05:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amisstea, pacho-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~components/monitoring/OWNERS~~ [pacho-rh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Dannyb48 · 2026-07-20T14:56:06Z

/agentic_review

Dannyb48 · 2026-07-20T18:21:26Z

Production Approval Record

Field	Value
Action	APPROVED
Reviewer	@Dannyb48
Timestamp	2026-07-20T18:21:20.804Z
Risk Level	low

openshift-ci Bot requested review from FaisalAl-Rayes and mftb July 17, 2026 16:31

github-actions Bot added environment/production infra/hold-production prod/needs-approval labels Jul 17, 2026

pacho-rh approved these changes Jul 17, 2026

View reviewed changes

openshift-ci Bot assigned pacho-rh Jul 17, 2026

openshift-ci Bot added the lgtm label Jul 17, 2026

openshift-ci Bot added the approved label Jul 17, 2026

Dannyb48 added prod/approved and removed prod/needs-approval labels Jul 20, 2026

Dannyb48 removed the infra/hold-production label Jul 20, 2026

openshift-merge-bot Bot merged commit fe56cb9 into redhat-appstudio:main Jul 20, 2026
28 of 30 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

KFLUXVNGD-1117 Add normalized_uri to production federation label allowlist#13109

KFLUXVNGD-1117 Add normalized_uri to production federation label allowlist#13109
openshift-merge-bot[bot] merged 1 commit into
redhat-appstudio:mainfrom
amisstea:KFLUXVNGD-1117

amisstea commented Jul 17, 2026 •

edited by atlassian Bot

Loading

Uh oh!

github-actions Bot commented Jul 17, 2026

Uh oh!

qodo-for-redhat-appstudio Bot commented Jul 17, 2026

Uh oh!

qodo-for-redhat-appstudio Bot commented Jul 17, 2026

Uh oh!

amisstea commented Jul 17, 2026

Uh oh!

github-actions Bot commented Jul 17, 2026

Uh oh!

codecov Bot commented Jul 17, 2026 •

edited

Loading

Uh oh!

pacho-rh left a comment

Uh oh!

openshift-ci Bot commented Jul 17, 2026

Uh oh!

Dannyb48 commented Jul 20, 2026

Uh oh!

Dannyb48 commented Jul 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

amisstea commented Jul 17, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Why

Validation

Risk Assessment

Uh oh!

github-actions Bot commented Jul 17, 2026

Kustomize Render Diff

Uh oh!

qodo-for-redhat-appstudio Bot commented Jul 17, 2026

PR Summary by Qodo

Uh oh!

qodo-for-redhat-appstudio Bot commented Jul 17, 2026

Code Review by Qodo

Great, no issues found!

Uh oh!

amisstea commented Jul 17, 2026

Uh oh!

github-actions Bot commented Jul 17, 2026

Uh oh!

codecov Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pacho-rh left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Jul 17, 2026

Uh oh!

Dannyb48 commented Jul 20, 2026

Uh oh!

Dannyb48 commented Jul 20, 2026

Production Approval Record

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

amisstea commented Jul 17, 2026 •

edited by atlassian Bot

Loading

codecov Bot commented Jul 17, 2026 •

edited

Loading