Skip to content
This repository was archived by the owner on Oct 27, 2025. It is now read-only.

Commit bc81fe7

Browse files
committed
Relax python3-requets dependency to >=2.20.0
Previous tentative to update python3-requests dependency to >=2.27 was not compatible with EL8 or EL9 which have respectively 2.20.0 and 2.25. Change-Id: I5cace767e12b19be816ca25fa464c1fb7283bf01
1 parent 0b99e5e commit bc81fe7

4 files changed

Lines changed: 6 additions & 7 deletions

File tree

dciclient/diff_jobs.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
from argparse import ArgumentParser
1818
import os
19-
import requests
2019
import sys
2120

2221
from dciclient.v1.api import job as dci_job
@@ -169,9 +168,6 @@ def main(argv=sys.argv, environ=os.environ):
169168

170169
try:
171170
response = run(context, args)
172-
except requests.exceptions.JSONDecodeError:
173-
sys.stderr.write("Invalid parameters.\n")
174-
return 1
175171
except Exception as ex:
176172
sys.stderr.write("Unable to perform request: %s.\n" % ex)
177173
return 1

python-dciclient.spec

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
%global summary Python client for DCI control server for the remote CIs
33

44
Name: python-%{srcname}
5-
Version: 4.0.1
5+
Version: 4.0.2
66
Release: 1.VERS%{?dist}
77
Summary: %{summary}
88

@@ -59,6 +59,9 @@ install -d %{buildroot}%{_bindir} %{buildroot}%{_datadir}/python-%{srcname}
5959

6060

6161
%changelog
62+
* Mon Sep 01 2025 François Charlier <fcharlie@redhat.com> 4.0.2-1
63+
- Update python3-requests requirement to >=2.20.0, <3.0
64+
6265
* Tue Jul 16 2024 Guillaume Vincent <gvincent@redhat.com> 4.0.1-1
6366
- Drop python 2
6467

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
PrettyTable>=0.7.2, <0.8
2-
requests>=2.27.0, <3.0
2+
requests>=2.20.0, <3.0
33
dciauth>= 2.1.7

tests/shell_commands/test_job.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ def test_diff_jobs(runner, job_id):
234234

235235

236236
def test_diff_jobs_invalid_parameter(runner, job_id):
237-
with pytest.raises(requests.exceptions.JSONDecodeError):
237+
with pytest.raises(Exception):
238238
runner.invoke_diff_jobs(["--job_id_1", "toto"])
239239

240240

0 commit comments

Comments
 (0)