feat: parameterise hardcoded OCP version in EE build configuration#13
Closed
shebistar wants to merge 1 commit into
Closed
feat: parameterise hardcoded OCP version in EE build configuration#13shebistar wants to merge 1 commit into
shebistar wants to merge 1 commit into
Conversation
Replace hardcoded rhocp-4.21 repo name with an OCP_VERSION build-arg (defaulting to 4.21) across all three EE versions. This eliminates the need to edit 6 locations across 3 files when updating the OCP dependency. Changes: - All EE versions: added ARG OCP_VERSION=4.21 to prepend_builder and prepend_final steps, replacing literal rhocp-4.21 in PKGMGR_OPTS - build-ee.yml: pass OCP_VERSION=4.21 as an explicit build-arg so the value is visible and overridable from CI Closes #9
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the hardcoded
rhocp-4.21repo name across all 3 EE versions with anOCP_VERSIONbuild-arg (default4.21), and exposes it in CI.Problem
6 hardcoded occurrences across 3 files required manual editing whenever OCP version changes. This introduces drift risk.
Changes
ee-2.4/execution-environment.yml,ee-2.5/execution-environment.yml,ee-2.6/execution-environment.yml: addedARG OCP_VERSION=4.21inprepend_builderandprepend_final.github/workflows/build-ee.yml: addedOCP_VERSION=4.21tobuild-argsTest plan
Closes #9
Made with Cursor