Skip to content

Commit f54510c

Browse files
authored
fix: add missing allowlist_externals for tox-ansible environments (#12) [skip ci]
* fix: add missing allowlist_externals for tox-ansible environments tox-ansible auto-generates test environments that use echo, git, ansible-galaxy, ansible-test, ansible-doc, pytest, mkdir, ln, and sh in commands_pre/commands. Without allowlist_externals, tox 4.x rejects these with "echo is not allowed, use allowlist_externals to allow it", causing all unit and integration test environments to fail. * fix: let tox-ansible manage test commands instead of overriding * fix: add distlib to integration requirements for manifest support * fix: add distlib to testenv deps for galaxy/sanity manifest support * fix: remove testenv overrides — only set allowlist_externals, let tox-ansible manage deps/commands * fix: add distlib to galaxy tox env for manifest support * fix: restore original testenv config, only add allowlist_externals
1 parent fd48942 commit f54510c

2 files changed

Lines changed: 8 additions & 0 deletions

File tree

tests/integration/requirements.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
11
# Add python packages that are required for integration testing
2+
distlib

tox-ansible.ini

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,15 @@ skip_install = false
5151
allowlist_externals =
5252
bash
5353
echo
54+
git
5455
mkdir
5556
sh
57+
ade
58+
ansible-galaxy
59+
ansible-test
60+
ansible-doc
61+
pytest
62+
ln
5663
commands =
5764
bash -c 'git init --initial-branch=main .'
5865
bash -c 'ansible-test integration'

0 commit comments

Comments
 (0)