fix: Remove dependencies from vm_networking role#27
Open
sabre1041 wants to merge 3 commits into
Open
Conversation
Signed-off-by: Andrew Block <andy.block@gmail.com>
sabre1041
force-pushed
the
remove-vm_networking-dependencies
branch
from
0b99a7d to
16fbf61
Compare
There was a problem hiding this comment.
Pull request overview
Removes the Ansible role meta dependency from vm_networking to decouple it from automatic dependency execution/installation behavior.
Changes:
- Removed
infra.openshift_virtualization_ops.vm_collectfromroles/vm_networking/meta/main.ymldependencies. - Replaced the prior dependency list with an explicit empty list (
dependencies: []).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - networking | ||
| dependencies: | ||
| - role: infra.openshift_virtualization_ops.vm_collect | ||
| dependencies: [] |
sabre1041
changed the title
Guard vm_collect include_role with a condition so callers can pass pre-populated vm_networking_vms and use the role without vm_collect. Add vm_networking_vms to defaults for discoverability.
Update Mermaid diagram, task table, and defaults table to reflect the conditional vm_collect inclusion and new vm_networking_vms default.
Author
|
@stevefulme1 Why were commits added to this PR? |
Author
|
@stevefulme1 can we fix up this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the hard dependency on
vm_collectfrom thevm_networkingrole.Why
The
vm_networkingrole previously declared a dependency oninfra.openshift_virtualization_ops.vm_collect, coupling the two roles together. Removing this dependency allowsvm_networkingto be used independently without automaticallypulling in
vm_collect, giving consumers more flexibility in how they compose roles.Changes
vm_collectrole dependency inroles/vm_networking/meta/main.ymlwith an empty dependencies list (dependencies: [])