Rename skipInstall to skip-install

Author: dgolovin

browser/model/installable-item.js

@@ -131,7 +131,7 @@ class InstallableItem {
   }
 
   isDownloadRequired() {
-    return !this.downloaded;
+    return this.useDownload && !this.downloaded;
   }
 
   setDownloadComplete() {

browser/services/componentLoader.js

@@ -91,17 +91,21 @@ class DynamicClass {
     let klass = require(`../${modulePath}`);
     let obj = klass.default.convertor.fromJson(config);
     if(skipInstall) {
-      obj.installAfterRequirements = installAfterRequirements.bind(obj);
-      obj.checkFiles = function() {};
+      obj.installAfterRequirements = skipInstallation.bind(this);
+      obj.checkFiles = skipOperation.bind(this);
       obj.useDownload = false;
     }
     return obj;
   }
 }
 
-function installAfterRequirements(progress, success) {
+function skipInstallation(progress, success) {
   progress.setStatus('Installing');
   success && success(true);
 }
 
+function skipOperation() {
+  return Promise.resolve();
+}
+
 export default ComponentLoader;

gulpfile.babel.js

@@ -116,7 +116,7 @@ gulp.task('run-clean', function(cb) {
 });
 
 gulp.task('run', ['update-requirements', 'create-modules-link', 'electron-rebuild'], function(cb) {
-  let skipInstall = process.argv.filter(name => name === '--skipInstall').length == 1 ? "skipInstall":"";
+  let skipInstall = process.argv.filter(name => name === '--skip-install').length == 1 ? "skip-install":"";
   exec(path.join('node_modules', '.bin') + path.sep + 'electron transpiled ' + skipInstall, common.createExecCallback(cb));
 });
 

main/index.js

@@ -93,8 +93,8 @@ app.on('ready', function() {
   if (process.platform === 'win32') {
     mainWindow.bundleTempFolder = process.argv.length > 1 ? process.argv[1].replace(/^--/, '') : undefined;
   }
-
-  mainWindow.skipInstall = process.argv.filter(name => name == 'skipInstall').length == 1;
+  console.log(process.argv);
+  mainWindow.skipInstall = process.argv.filter(name => name == 'skip-install').length == 1;
 
   mainWindow.once('ready-to-show', () => {
     mainWindow.show();