Skip to content

Commit 58693cf

Browse files
committed
Remove unused case condition; rename action
Signed-off-by: Keith Chong <kykchong@redhat.com>
1 parent 8ce6d6e commit 58693cf

5 files changed

Lines changed: 7 additions & 12 deletions

File tree

locales/en/plugin__gitops-plugin.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,7 @@
150150
"Applications": "Applications",
151151
"Edit ApplicationSet": "Edit ApplicationSet",
152152
"Delete ApplicationSet": "Delete ApplicationSet",
153+
"View Graph": "View Graph",
153154
"AppSet ownerReference Tree View": "AppSet ownerReference Tree View",
154155
"Progressive Sync Flow View": "Progressive Sync Flow View",
155156
"Expand or collapse all progressive sync step groups": "Expand or collapse all progressive sync step groups",

locales/ja/plugin__gitops-plugin.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,7 @@
150150
"Applications": "Applications",
151151
"Edit ApplicationSet": "Edit ApplicationSet",
152152
"Delete ApplicationSet": "Delete ApplicationSet",
153+
"View Graph": "View Graph",
153154
"AppSet ownerReference Tree View": "AppSet ownerReference Tree View",
154155
"Progressive Sync Flow View": "Progressive Sync Flow View",
155156
"Expand or collapse all progressive sync step groups": "Expand or collapse all progressive sync step groups",

locales/ko/plugin__gitops-plugin.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,7 @@
150150
"Applications": "Applications",
151151
"Edit ApplicationSet": "Edit ApplicationSet",
152152
"Delete ApplicationSet": "Delete ApplicationSet",
153+
"View Graph": "View Graph",
153154
"AppSet ownerReference Tree View": "AppSet ownerReference Tree View",
154155
"Progressive Sync Flow View": "Progressive Sync Flow View",
155156
"Expand or collapse all progressive sync step groups": "Expand or collapse all progressive sync step groups",

locales/zh/plugin__gitops-plugin.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,7 @@
150150
"Applications": "Applications",
151151
"Edit ApplicationSet": "Edit ApplicationSet",
152152
"Delete ApplicationSet": "Delete ApplicationSet",
153+
"View Graph": "View Graph",
153154
"AppSet ownerReference Tree View": "AppSet ownerReference Tree View",
154155
"Progressive Sync Flow View": "Progressive Sync Flow View",
155156
"Expand or collapse all progressive sync step groups": "Expand or collapse all progressive sync step groups",

src/gitops/components/appset/graph/ApplicationSetGraphView.tsx

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,7 @@ import * as React from 'react';
22
import { NavigateFunction, useNavigate } from 'react-router-dom-v5-compat';
33
import { observer } from 'mobx-react';
44

5-
import {
6-
ApplicationKind,
7-
ApplicationModel,
8-
applicationModelRef,
9-
} from '@gitops/models/ApplicationModel';
5+
import { ApplicationKind, ApplicationModel } from '@gitops/models/ApplicationModel';
106
import { ApplicationSetKind, applicationSetModelRef } from '@gitops/models/ApplicationSetModel';
117
import { HealthStatus } from '@gitops/utils/constants';
128
import { ArgoServer, getArgoServer } from '@gitops/utils/gitops';
@@ -205,11 +201,6 @@ const AppSetContextMenuItem: React.FC<AppSetContextMenuItemProps> = ({
205201
case t('Edit annotations'):
206202
launchAnnotationsModal();
207203
break;
208-
case t('Edit Application'):
209-
navigate(
210-
`/k8s/ns/${applicationSet.metadata?.namespace}/${applicationModelRef}/${applicationSet.metadata?.name}/yaml`,
211-
);
212-
break;
213204
case t('Edit ApplicationSet'):
214205
navigate(
215206
`/k8s/ns/${applicationSet.metadata?.namespace}/${applicationSetModelRef}/${applicationSet.metadata?.name}/yaml`,
@@ -219,7 +210,7 @@ const AppSetContextMenuItem: React.FC<AppSetContextMenuItemProps> = ({
219210
case t('Delete ApplicationSet'):
220211
launchDeleteModal();
221212
break;
222-
case t('View Details'):
213+
case t('View Graph'):
223214
navigate(graphElement.getData().resourcePath);
224215
break;
225216
}
@@ -276,7 +267,7 @@ const getResourceMenuItems = (
276267
paramsRef,
277268
t('Delete Application'),
278269
'-',
279-
t('View Details'),
270+
t('View Graph'),
280271
t('View in Argo CD'),
281272
);
282273
}

0 commit comments

Comments
 (0)