address Coderabbit PR review feedback

Signed-off-by: Triona Doyle <tekton@example.com>

Author: Triona Doyle

test/ui-e2e/.auth/setup.ts

@@ -56,6 +56,7 @@ setup('authenticate to OpenShift Cluster', async ({ page, baseURL }) => {
   await page.getByRole('button', { name: /Log in/i }).click();
 
   // Save the auth state
-  await page.waitForLoadState('networkidle');
+  await expect(page.getByRole('navigation').first()).toBeVisible({ timeout: 15000 });
   await page.context().storageState({ path: authFile });
+
 });

test/ui-e2e/src/fixtures.ts

@@ -13,7 +13,20 @@ export const test = base.extend<MyFixtures>({
   page: async ({ page }, use) => {
     const loginPage = new LoginPage(page);
     await loginPage.goto();
-    await loginPage.loginViaOpenShift();
+    
+    // 1. Grab variables from the environment
+    const user = process.env.CLUSTER_USER || 'kubeadmin';
+    const pass = process.env.CLUSTER_PASSWORD;
+    const idp = process.env.IDP || 'kube:admin';
+
+    // 2. Fail loudly if the password is missing
+    if (!pass) {
+      throw new Error('CLUSTER_PASSWORD environment variable is missing. Cannot authenticate.');
+    }
+
+    // 3. Pass them into the login method
+    await loginPage.loginViaOpenShift(user, pass, idp);
+    
     await use(page);
   },
 
@@ -41,9 +54,9 @@ export const test = base.extend<MyFixtures>({
       headers: { 'Content-Type': 'application/json' }
     });
 
-    //ignore if missing or rbac locked
-    if (response.status() === 404 || response.status() === 403) {
-      if (response.status() === 403) console.log('warning: delete forbidden (RBAC) on this cluster; skipping cleanup');
+    // 4. Update the teardown to only ignore 404s, treating 403s as failures
+    if (response.status() === 404) {
+      return; 
     } else {
       expect(response.status()).toBeLessThan(400);
     }

test/ui-e2e/src/pages/ApplicationsPage.ts

@@ -76,7 +76,7 @@ export class ApplicationsPage {
     await this.createButton.click();
   }
 
-  async syncApplication(appName: string) {
+  async syncApplication(appName: string, expectedResource: string = 'spring-petclinic') {
     //search for app
     await this.page.getByPlaceholder(/Search applications/i).fill(appName);
 
@@ -86,7 +86,7 @@ export class ApplicationsPage {
 
     //slideout panel 
     const resourcesSection = this.page.locator('.argo-form-row').filter({ hasText: 'SYNCHRONIZE RESOURCES' });
-    await expect(resourcesSection).toContainText('spring-petclinic', { timeout: 15000 });
+    await expect(resourcesSection).toContainText(expectedResource, { timeout: 15000 });
 
     const validationWarning = resourcesSection.getByText('Select at least one resource');
 

test/ui-e2e/src/pages/LoginPage.ts

@@ -37,7 +37,10 @@ export class LoginPage {
     }
 
     //check if manual login is actually required
-    const usernameInput = this.page.getByLabel(/Username/i);
+    const usernameInput = this.page.getByLabel(/Username/i)
+                                   .or(this.page.locator('input[name="username"]'))
+                                   .or(this.page.getByPlaceholder(/Username/i));
+                                   
     const needsLogin = await usernameInput.waitFor({ state: 'visible', timeout: 5000 }).then(() => true).catch(() => false);
 
     if (needsLogin && user && pass) {