use IsOpenshitCluster to gate openshift specific capabilities

Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com>

Author: anandrkskd

cmd/main.go

@@ -223,6 +223,7 @@ func main() {
 	registerComponentOrExit(mgr, argov1beta1api.AddToScheme)
 
 	// Setup Scheme for OpenShift Config if available
+	// Disables default Argo CD instance if the cluster doesn't contain OpenShift config API
 	var disableDefault bool
 	disableDefault = strings.ToLower(os.Getenv(common.DisableDefaultInstallEnvVar)) == "true"
 	if util.IsConfigAPIFound() {
@@ -259,13 +260,17 @@ func main() {
 		}
 	}
 
-	if err = (&controllers.ReconcileGitopsService{
-		Client:                client,
-		Scheme:                mgr.GetScheme(),
-		DisableDefaultInstall: disableDefault,
-	}).SetupWithManager(mgr); err != nil {
-		setupLog.Error(err, "unable to create controller", "controller", "GitopsService")
-		os.Exit(1)
+	if util.IsOpenShiftCluster() {
+		if err = (&controllers.ReconcileGitopsService{
+			Client:                client,
+			Scheme:                mgr.GetScheme(),
+			DisableDefaultInstall: disableDefault,
+		}).SetupWithManager(mgr); err != nil {
+			setupLog.Error(err, "unable to create controller", "controller", "GitopsService")
+			os.Exit(1)
+		}
+	} else {
+		setupLog.Info("Non-OpenShift cluster detected, skipping GitopsService controller setup")
 	}
 
 	if util.IsRouteAPIFound() {

controllers/argocd/argocd.go

@@ -94,7 +94,7 @@ func getArgoDexSpec() *argoapp.ArgoCDDexSpec {
 }
 
 func getArgoSSOSpec(client client.Client) *argoapp.ArgoCDSSOSpec {
-	if !util.IsConfigAPIFound() {
+	if !util.IsOpenShiftCluster() {
 		log.Info("non-OpenShift cluster detected, skipping SSO/Dex configuration")
 		return nil
 	}

controllers/util/util.go

@@ -121,6 +121,11 @@ func IsConfigAPIFound() bool {
 	return configAPIFound
 }
 
+// used as a shortcut to check if the cluster is an OpenShift cluster
+func IsOpenShiftCluster() bool {
+	return configAPIFound
+}
+
 // verify if the Config.Openshift.io API is found
 func verifyConfigAPI() error {
 	found, err := argoutil.VerifyAPI(configv1.GroupName, configv1.GroupVersion.Version)