Update

Author: jgwest

test/openshift/e2e/ginkgo/fixture/fixture.go

@@ -895,10 +895,7 @@ func outputPodLog(podSubstring string) {
 	// Output only the last 1000 lines
 	lines := strings.Split(kubectlLogOutput, "\n")
 
-	startIndex := len(lines) - 1000
-	if startIndex < 0 {
-		startIndex = 0
-	}
+	startIndex := max(len(lines)-1000, 0)
 
 	GinkgoWriter.Println("")
 	GinkgoWriter.Println("----------------------------------------------------------------")

test/openshift/e2e/ginkgo/sequential/1-003_validate_cluster_config_test.go

@@ -59,6 +59,8 @@ var _ = Describe("GitOps Operator Sequential E2E Tests", func() {
 			ns, cleanupFunc := fixture.CreateNamespaceWithCleanupFunc("argocd-e2e-cluster-config")
 			defer cleanupFunc()
 
+			defer fixture.OutputDebugOnFail("argocd-e2e-cluster-config", "openshift-gitops")
+
 			By("creating simple namespace-scoped ArgoCD instance .spec.initialSSHKnownHosts set")
 			argoCD := &argov1beta1api.ArgoCD{
 				ObjectMeta: metav1.ObjectMeta{Name: "example-argocd", Namespace: ns.Name},
@@ -76,6 +78,7 @@ var _ = Describe("GitOps Operator Sequential E2E Tests", func() {
 			fixture.SetEnvInOperatorSubscriptionOrDeployment("ARGOCD_CLUSTER_CONFIG_NAMESPACES", "openshift-gitops, argocd-e2e-cluster-config")
 
 			defer fixture.RestoreSubcriptionToDefault() // revert Subscription at end of test
+			defer fixture.OutputDebugOnFail("argocd-e2e-cluster-config", "openshift-gitops")
 
 			By("verifying ClusterRole/Binding were created for argocd-e2e-cluster-config server/app controller components, now that the namespace is specified in the CLUSTER_CONFIG env var")
 			appControllerCR := &rbacv1.ClusterRole{ObjectMeta: metav1.ObjectMeta{Name: "example-argocd-argocd-e2e-cluster-config-argocd-application-controller"}}