fix: prevent IDE freeze and threading violations in Stack Analysis and Component Analysis (#245)

soul2zimate · claude · web-flow · commit 51f85af9dce4 · 2026-03-26T13:29:05.000+08:00
* fix: replace runReadAction with invokeLater for DaemonCodeAnalyzer.restart() calls

* fix: dispatch refreshAndFindFileByPath to background thread to avoid SlowOperations on EDT

* fix: handle project disposal race in SA report opening and avoid redundant VFS refresh

* fix: add disposal guards and user-visible error for async editor operations

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;

---------

Co-authored-by: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/src/main/java/org/jboss/tools/intellij/componentanalysis/CAAnnotator.java b/src/main/java/org/jboss/tools/intellij/componentanalysis/CAAnnotator.java
@@ -79,7 +79,7 @@ public abstract class CAAnnotator extends ExternalAnnotator<CAAnnotator.Info, Ma
                                 dependencies,
                                 info.getFile());
 
-                        ApplicationManager.getApplication().runReadAction(() -> {
+                        ApplicationManager.getApplication().invokeLater(() -> {
                             if (updated) {
                                 LOG.info("Refresh dependencies");
                                 try {
diff --git a/src/main/java/org/jboss/tools/intellij/componentanalysis/SAIntentionAction.java b/src/main/java/org/jboss/tools/intellij/componentanalysis/SAIntentionAction.java
@@ -62,7 +62,7 @@ public void invoke(@NotNull Project project, Editor editor, PsiFile file) throws
             if (manifestDetails != null) {
                 try {
                     AnalyticsReportUtils analyticsReportUtils = new AnalyticsReportUtils();
-                    analyticsReportUtils.openCustomEditor(FileEditorManager.getInstance(project), manifestDetails);
+                    analyticsReportUtils.openCustomEditor(FileEditorManager.getInstance(project), manifestDetails, project);
                 } catch (IOException ex) {
                     throw new RuntimeException(ex);
                 }
diff --git a/src/main/java/org/jboss/tools/intellij/image/DockerfileAnnotator.java b/src/main/java/org/jboss/tools/intellij/image/DockerfileAnnotator.java
@@ -287,7 +287,7 @@ private static HighlightSeverity getHighlightSeverity(AnalysisReport report, Str
 
                     var updated = imageService.performAnalysis(new HashSet<>(images), info.getFile().getProject());
 
-                    ApplicationManager.getApplication().runReadAction(() -> {
+                    ApplicationManager.getApplication().invokeLater(() -> {
                         if (updated) {
                             LOG.info("Refresh vulnerabilities");
                             try {
diff --git a/src/main/java/org/jboss/tools/intellij/image/ImageService.java b/src/main/java/org/jboss/tools/intellij/image/ImageService.java
@@ -232,7 +232,7 @@ void openAnalysisHtmlReport(Project project, PsiFile dockerfile) {
                             ApplicationManager.getApplication().invokeLater(() -> {
                                 try {
                                     var analyticsReportUtils = new AnalyticsReportUtils();
-                                    analyticsReportUtils.openCustomEditor(FileEditorManager.getInstance(project), manifestDetails);
+                                    analyticsReportUtils.openCustomEditor(FileEditorManager.getInstance(project), manifestDetails, project);
                                 } catch (Exception e) {
                                     LOGGER.error(e);
                                     Messages.showErrorDialog(project,
diff --git a/src/main/java/org/jboss/tools/intellij/report/AnalyticsReportUtils.java b/src/main/java/org/jboss/tools/intellij/report/AnalyticsReportUtils.java
@@ -12,10 +12,16 @@
 
 import com.google.gson.Gson;
 import com.google.gson.JsonObject;
+import com.intellij.openapi.application.ApplicationManager;
+import com.intellij.openapi.application.ModalityState;
+import com.intellij.openapi.diagnostic.Logger;
 import com.intellij.openapi.fileEditor.FileEditorManager;
+import com.intellij.openapi.project.Project;
+import com.intellij.openapi.ui.Messages;
 import com.intellij.openapi.vfs.LocalFileSystem;
 import com.intellij.openapi.vfs.VfsUtilCore;
 import com.intellij.openapi.vfs.VirtualFile;
+import com.intellij.serviceContainer.AlreadyDisposedException;
 
 import java.io.BufferedWriter;
 import java.io.File;
@@ -26,22 +32,30 @@
 
 public class AnalyticsReportUtils {
 
+    private static final Logger LOG = Logger.getInstance(AnalyticsReportUtils.class);
+
     /**
      * <p>Open a custom editor window.</p>
      *
      * <p>The custom editor window will open a file which will have browser attached to it.</p>
      *
+     * <p>Must be called on the EDT. The slow VFS operation ({@code refreshAndFindFileByPath})
+     * is dispatched internally to a background thread to avoid blocking the EDT.</p>
+     *
      * @param instance        An instance of FileEditorManager.
      * @param manifestDetails Manifest file details.
+     * @param project         The project owning the editor; used as a disposal guard.
      * @throws IOException In case of process failure
      */
-    public void openCustomEditor(FileEditorManager instance, JsonObject manifestDetails) throws IOException {
+    public void openCustomEditor(FileEditorManager instance, JsonObject manifestDetails, Project project) throws IOException {
 
         // Close custom editor if already opened in previous run,
         // if it's a different manifest file with same name then don't close existing one and open a new tab.
+        // NOTE: must run before file creation so that showParent flag is included in the written content.
         manifestDetails = closeCustomEditor(instance, manifestDetails);
 
         // Create a temp file in which is registered with AnalyticsReportEditorProvider.
+        // Standard Java file I/O — not a VFS operation, safe on EDT.
         File reportFile = File.createTempFile("exhort-", "_" + manifestDetails.get("manifestName").getAsString() + ".ar");
 
         //Save the Analytics Report URL in file, which will be loaded in browser
@@ -59,18 +73,32 @@ public void openCustomEditor(FileEditorManager instance, JsonObject manifestDeta
             );
         }
 
-        // Create a virtual file from report file
-        VirtualFile virtualFile = LocalFileSystem.getInstance().refreshAndFindFileByPath(reportFile.getAbsolutePath());
-
-        // Refresh the cached file from the physical file system.
-        // if Virtual file is already opened in editor window from previous run then refresh file from physical file
-        // else old web page will be shown in editor window.
-        if (virtualFile == null) {
-            throw new PlatformDetectionException("Dependency Analytics Report file is not created.");
-        }
-        virtualFile.refresh(true, true, () -> {
-            // Open the virtual file in editor window, which will show the analytics report.
-            instance.openFile(virtualFile, true, false);
+        // refreshAndFindFileByPath is a slow VFS operation prohibited on EDT.
+        // Dispatch to a background thread; once the VirtualFile is obtained, switch back to EDT to open it.
+        ApplicationManager.getApplication().executeOnPooledThread(() -> {
+            if (project.isDisposed()) {
+                return;
+            }
+            VirtualFile virtualFile = LocalFileSystem.getInstance().refreshAndFindFileByPath(reportFile.getAbsolutePath());
+            if (virtualFile == null) {
+                LOG.error("Dependency Analytics Report file is not created.");
+                ApplicationManager.getApplication().invokeLater(() ->
+                        Messages.showErrorDialog(project,
+                                "Dependency Analytics Report file could not be created.",
+                                "Error"),
+                        ModalityState.defaultModalityState());
+                return;
+            }
+            // refreshAndFindFileByPath already performed a synchronous refresh and fully
+            // registered the file with the VFS — no second refresh is needed.
+            // Switch to EDT to open the editor tab, guarded by project disposal.
+            ApplicationManager.getApplication().invokeLater(() -> {
+                try {
+                    instance.openFile(virtualFile, true, false);
+                } catch (AlreadyDisposedException e) {
+                    // Project was disposed after the runnable was scheduled — ignore.
+                }
+            }, ModalityState.defaultModalityState(), project.getDisposed());
         });
     }
 
diff --git a/src/main/java/org/jboss/tools/intellij/settings/ApiSettingsConfigurable.java b/src/main/java/org/jboss/tools/intellij/settings/ApiSettingsConfigurable.java
@@ -16,6 +16,7 @@
 import com.intellij.openapi.project.Project;
 import com.intellij.openapi.project.ProjectManager;
 import com.intellij.openapi.util.NlsContexts;
+import com.intellij.serviceContainer.AlreadyDisposedException;
 import org.jetbrains.annotations.Nullable;
 
 import javax.swing.JComponent;
@@ -116,11 +117,15 @@ public void apply() {
     }
 
     private void refreshComponentAnalysis() {
-        ApplicationManager.getApplication().runReadAction(() -> {
+        ApplicationManager.getApplication().invokeLater(() -> {
             Project[] openProjects = ProjectManager.getInstance().getOpenProjects();
             for (Project project : openProjects) {
                 if (!project.isDisposed()) {
-                    DaemonCodeAnalyzer.getInstance(project).restart();
+                    try {
+                        DaemonCodeAnalyzer.getInstance(project).restart();
+                    } catch (AlreadyDisposedException e) {
+                        // Project was disposed between the isDisposed() check and restart() — ignore.
+                    }
                 }
             }
         });
diff --git a/src/main/java/org/jboss/tools/intellij/stackanalysis/SaAction.java b/src/main/java/org/jboss/tools/intellij/stackanalysis/SaAction.java
@@ -24,6 +24,7 @@
 import com.intellij.openapi.ui.Messages;
 import com.intellij.openapi.vfs.VirtualFile;
 import com.intellij.psi.PsiFile;
+import com.intellij.serviceContainer.AlreadyDisposedException;
 import org.jboss.tools.intellij.report.AnalyticsReportUtils;
 import org.jetbrains.annotations.NotNull;
 
@@ -82,10 +83,15 @@ public void actionPerformed(@NotNull AnActionEvent event) {
 
                     if (manifestDetails != null) {
                         ApplicationManager.getApplication().invokeLater(() -> {
+                            if (project.isDisposed()) {
+                                return;
+                            }
                             try {
                                 AnalyticsReportUtils analyticsReportUtils = new AnalyticsReportUtils();
                                 // Open custom editor window which will load SA Report in browser attached to it.
-                                analyticsReportUtils.openCustomEditor(FileEditorManager.getInstance(project), manifestDetails);
+                                analyticsReportUtils.openCustomEditor(FileEditorManager.getInstance(project), manifestDetails, project);
+                            } catch (AlreadyDisposedException e) {
+                                // Project was disposed between the isDisposed() check and getInstance() — ignore silently.
                             } catch (Exception e) {
                                 logger.error(e);
                                 Messages.showErrorDialog(event.getProject(),

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ public void invoke(@NotNull Project project, Editor editor, PsiFile file) throws`
`62`	`62`	`if (manifestDetails != null) {`
`63`	`63`	`try {`
`64`	`64`	`AnalyticsReportUtils analyticsReportUtils = new AnalyticsReportUtils();`
`65`		`- analyticsReportUtils.openCustomEditor(FileEditorManager.getInstance(project), manifestDetails);`
	`65`	`+ analyticsReportUtils.openCustomEditor(FileEditorManager.getInstance(project), manifestDetails, project);`
`66`	`66`	`} catch (IOException ex) {`
`67`	`67`	`throw new RuntimeException(ex);`
`68`	`68`	`}`