Skip to content

fix: TC-2796 add more standard configuration names to lexer and grammar of build.gradle - #206

Merged
soul2zimate merged 2 commits into
redhat-developer:mainfrom
soul2zimate:TC-2796
Aug 27, 2025
Merged

fix: TC-2796 add more standard configuration names to lexer and grammar of build.gradle#206
soul2zimate merged 2 commits into
redhat-developer:mainfrom
soul2zimate:TC-2796

Conversation

@soul2zimate

Copy link
Copy Markdown
Contributor

fix: TC-2796 add more standard configuration names to lexer and grammar of build.gradle

issue: https://issues.redhat.com/browse/TC-2796

QE found an issue that test dependency declaration in build.gradle cannot be properly parsed i.e,:

    testRuntimeOnly "io.quarkus:quarkus-resteasy:2.13.5.Final"
    testImplementation "io.quarkus:quarkus-jdbc-postgresql:2.13.5.Final"
    testCompileOnly "io.quarkus:quarkus-vertx-http:2.13.5.Final"

From intelliJ, it shows errors like:

<artifact>, <comment>, BuildGradleTokenType.", BuildGradleTokenType.', BuildGradleTokenType.,, BuildGradleTokenType.APPLICATION, BuildGradleTokenType.CRLF, BuildGradleTokenType.EXT, BuildGradleTokenType.GROUP_ID, BuildGradleTokenType.GROUP_KEY, BuildGradleTokenType.ID_PREFIX, BuildGradleTokenType.INTELLIJ, BuildGradleTokenType.JAVAFX, BuildGradleTokenType.JLINKZIP, BuildGradleTokenType.JLINK_COMPONENT, BuildGradleTokenType.JLINK_START, BuildGradleTokenType.PLUGINS, BuildGradleTokenType.RCURBRACE, BuildGradleTokenType.ROOT_GENERIC_KEY, BuildGradleTokenType.ROOT_GROUP_KEY, BuildGradleTokenType.ROOT_VERSION_KEY, BuildGradleTokenType.RUNIDE, BuildGradleTokenType.SPACE_CHARACTER, BuildGradleTokenType.TASKS, BuildGradleTokenType.dependencies, BuildGradleTokenType.java, BuildGradleTokenType.main, BuildGradleTokenType.repositories, BuildGradleTokenType.sourceSets, BuildGradleTokenType.test or BuildGradleTokenType.{ expected, got 'testImplementation "...'

Since the plugin defines its own file type rhda-build-gradle for build.gradle , I checked CONFIG_NAME in buildGradle.bnf and CONFIG_NAME in buildGradle.flex , those test* configuration names are not accepted.

…ar of build.gradle

Signed-off-by: Chao Wang <chaowan@redhat.com>
Signed-off-by: Chao Wang <chaowan@redhat.com>
@sonarqubecloud

Copy link
Copy Markdown

@soul2zimate

Copy link
Copy Markdown
Contributor Author

Hi @zvigrinberg, Could you please review this change ? Thanks.

@soul2zimate
soul2zimate merged commit b26b080 into redhat-developer:main Aug 27, 2025
8 checks passed
@soul2zimate
soul2zimate deleted the TC-2796 branch August 27, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants