Skip to content

fix: allow Inline Vulnerability Severity Alerts level change in Dockerfile #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soul2zimate merged 1 commit into from
Dec 17, 2025
Merged

fix: allow Inline Vulnerability Severity Alerts level change in Dockerfile #235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions src/main/java/org/jboss/tools/intellij/image/DockerfileAnnotator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import com.github.packageurl.MalformedPackageURLException;
import com.intellij.codeInsight.daemon.DaemonCodeAnalyzer;
import com.intellij.codeInsight.daemon.HighlightDisplayKey;
import com.intellij.codeHighlighting.HighlightDisplayLevel;
import com.intellij.codeInspection.InspectionProfileEntry;
import com.intellij.lang.annotation.AnnotationHolder;
import com.intellij.lang.annotation.ExternalAnnotator;
Expand Down Expand Up @@ -234,6 +235,25 @@ static String getRecommendation(AnalysisReport report, ImageRef imageRef) {
.orElse(null);
}

@NotNull
private static HighlightSeverity getHighlightSeverity(AnalysisReport report, String recommendation, boolean hasIssue, @NotNull PsiElement context) {
// Get the configured severity from the inspection settings
final InspectionProfileEntry inspection = getInspection(context);
if (inspection != null) {
final var profile = InspectionProjectProfileManager.getInstance(context.getProject()).getCurrentProfile();
final HighlightDisplayKey key = HighlightDisplayKey.find(DockerfileInspection.SHORT_NAME);
if (key != null) {
HighlightDisplayLevel level = profile.getErrorLevel(key, context);
return level.getSeverity();
}
}

// Fallback to original logic if inspection settings can't be determined
return hasIssue || recommendation == null ?
HighlightSeverity.ERROR :
HighlightSeverity.WEAK_WARNING;
}

@Override
public @Nullable Info collectInformation(@NotNull PsiFile file) {
// Only process our custom Dockerfile type
Expand Down Expand Up @@ -318,11 +338,8 @@ public void apply(@NotNull PsiFile file, Map<BaseImage, Result> annotationResult
var message = generateMessage(key.getImageName(), report, recommendation);
var tooltip = generateTooltip(key.getImageName(), report, recommendation);

var severity = hasIssue || recommendation == null ?
HighlightSeverity.ERROR :
HighlightSeverity.WEAK_WARNING;

elements.forEach(e -> {
var severity = getHighlightSeverity(report, recommendation, hasIssue, e);
if (e != null) {
var builder = holder
.newAnnotation(severity, message)
Expand Down
Loading