Skip to content

chore: prepare release 1.3.0#251

Merged
ruromero merged 1 commit into
redhat-developer:mainfrom
ruromero:prepare-1.3.0
Apr 14, 2026
Merged

chore: prepare release 1.3.0#251
ruromero merged 1 commit into
redhat-developer:mainfrom
ruromero:prepare-1.3.0

Conversation

@ruromero

Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>
@qodo-code-review

Copy link
Copy Markdown

Review Summary by Qodo

Release version 1.3.0 preparation

📦 Other

Grey Divider

Walkthroughs

Description
• Update project version from 1.3.0-SNAPSHOT to 1.3.0
• Add newline at end of gradle.properties file
Diagram
flowchart LR
  A["gradle.properties"] -- "Update version to 1.3.0" --> B["Release 1.3.0"]
  A -- "Fix file formatting" --> B
Loading

Grey Divider

File Changes

1. gradle.properties ⚙️ Configuration changes +2/-2

Update version to 1.3.0 release

• Update projectVersion from 1.3.0-SNAPSHOT to 1.3.0
• Add missing newline at end of file for proper formatting

gradle.properties


Grey Divider

Qodo Logo

@ruromero
ruromero merged commit b1062b8 into redhat-developer:main Apr 14, 2026
5 checks passed
@qodo-code-review

qodo-code-review Bot commented Apr 14, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1)   📘 Rule violations (0)   📎 Requirement gaps (0)
🐞\ ≡ Correctness (1)

Grey Divider


Action required

1. Nightly suffix no-op 🐞
Description
Nightly publishing computes VERSION by replacing "-SNAPSHOT" in projectVersion, but projectVersion
is now "1.3.0" so the replacement is a no-op and nightly builds will publish as the plain release
version (no "-nightly.<date>" suffix). This breaks the workflow’s stated intent to generate
date-stamped nightly versions and can cause version collisions across nightly runs.
Code

gradle.properties[1]

+projectVersion=1.3.0
Evidence
The PR changes the base version to a non-SNAPSHOT value. The nightly workflow reads that value from
gradle.properties and derives nightly versions via bash substitution that only changes strings
containing "-SNAPSHOT"; without it, VERSION stays equal to BASE_VERSION. The Gradle build uses
projectVersion as the plugin version, and the workflow passes the computed VERSION back into Gradle
via -PprojectVersion, so the incorrect derived version propagates to the published artifact.

gradle.properties[1-3]
.github/workflows/publish-marketplace.yml[72-111]
build.gradle.kts[12-14]
.github/workflows/publish-marketplace.yml[113-123]
.github/workflows/publish-marketplace.yml[174-183]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Nightly version computation in `.github/workflows/publish-marketplace.yml` relies on replacing `-SNAPSHOT` in `projectVersion`. After this PR sets `projectVersion=1.3.0`, the replacement becomes a no-op, so nightly runs produce `VERSION=1.3.0` instead of `1.3.0-nightly.<date>`.

## Issue Context
The workflow explicitly comments that it wants versions like `1.1.0-nightly.20240901`, but the current bash substitution only works when the base version contains `-SNAPSHOT`.

## Fix Focus Areas
- .github/workflows/publish-marketplace.yml[72-111]

## Suggested change
Update the nightly version calculation to append a nightly suffix even when the base version is not a `-SNAPSHOT`, e.g.:

```bash
BASE_VERSION=$(grep 'projectVersion=' gradle.properties | cut -d'=' -f2)
DATE=$(date +%Y%m%d)
if [[ "$BASE_VERSION" == *"-SNAPSHOT" ]]; then
 VERSION="${BASE_VERSION/-SNAPSHOT/-nightly.${DATE}}"
else
 VERSION="${BASE_VERSION}-nightly.${DATE}"
fi
```

Alternatively, keep `projectVersion` as `x.y.z-SNAPSHOT` on the default branch and rely on `-PprojectVersion` overrides for release publishing.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@sonarqubecloud

Copy link
Copy Markdown

Comment thread gradle.properties
@@ -1,4 +1,4 @@
projectVersion=1.3.0-SNAPSHOT
projectVersion=1.3.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Nightly suffix no-op 🐞 Bug ≡ Correctness

Nightly publishing computes VERSION by replacing "-SNAPSHOT" in projectVersion, but projectVersion
is now "1.3.0" so the replacement is a no-op and nightly builds will publish as the plain release
version (no "-nightly.<date>" suffix). This breaks the workflow’s stated intent to generate
date-stamped nightly versions and can cause version collisions across nightly runs.
Agent Prompt
## Issue description
Nightly version computation in `.github/workflows/publish-marketplace.yml` relies on replacing `-SNAPSHOT` in `projectVersion`. After this PR sets `projectVersion=1.3.0`, the replacement becomes a no-op, so nightly runs produce `VERSION=1.3.0` instead of `1.3.0-nightly.<date>`.

## Issue Context
The workflow explicitly comments that it wants versions like `1.1.0-nightly.20240901`, but the current bash substitution only works when the base version contains `-SNAPSHOT`.

## Fix Focus Areas
- .github/workflows/publish-marketplace.yml[72-111]

## Suggested change
Update the nightly version calculation to append a nightly suffix even when the base version is not a `-SNAPSHOT`, e.g.:

```bash
BASE_VERSION=$(grep 'projectVersion=' gradle.properties | cut -d'=' -f2)
DATE=$(date +%Y%m%d)
if [[ "$BASE_VERSION" == *"-SNAPSHOT" ]]; then
  VERSION="${BASE_VERSION/-SNAPSHOT/-nightly.${DATE}}"
else
  VERSION="${BASE_VERSION}-nightly.${DATE}"
fi
```

Alternatively, keep `projectVersion` as `x.y.z-SNAPSHOT` on the default branch and rely on `-PprojectVersion` overrides for release publishing.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant