chore: prepare release 1.3.0#251
Merged
Merged
Conversation
Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>
Review Summary by QodoRelease version 1.3.0 preparation
WalkthroughsDescription• Update project version from 1.3.0-SNAPSHOT to 1.3.0 • Add newline at end of gradle.properties file Diagramflowchart LR
A["gradle.properties"] -- "Update version to 1.3.0" --> B["Release 1.3.0"]
A -- "Fix file formatting" --> B
File Changes1. gradle.properties
|
Code Review by Qodo
|
|
| @@ -1,4 +1,4 @@ | |||
| projectVersion=1.3.0-SNAPSHOT | |||
| projectVersion=1.3.0 | |||
There was a problem hiding this comment.
1. Nightly suffix no-op 🐞 Bug ≡ Correctness
Nightly publishing computes VERSION by replacing "-SNAPSHOT" in projectVersion, but projectVersion is now "1.3.0" so the replacement is a no-op and nightly builds will publish as the plain release version (no "-nightly.<date>" suffix). This breaks the workflow’s stated intent to generate date-stamped nightly versions and can cause version collisions across nightly runs.
Agent Prompt
## Issue description
Nightly version computation in `.github/workflows/publish-marketplace.yml` relies on replacing `-SNAPSHOT` in `projectVersion`. After this PR sets `projectVersion=1.3.0`, the replacement becomes a no-op, so nightly runs produce `VERSION=1.3.0` instead of `1.3.0-nightly.<date>`.
## Issue Context
The workflow explicitly comments that it wants versions like `1.1.0-nightly.20240901`, but the current bash substitution only works when the base version contains `-SNAPSHOT`.
## Fix Focus Areas
- .github/workflows/publish-marketplace.yml[72-111]
## Suggested change
Update the nightly version calculation to append a nightly suffix even when the base version is not a `-SNAPSHOT`, e.g.:
```bash
BASE_VERSION=$(grep 'projectVersion=' gradle.properties | cut -d'=' -f2)
DATE=$(date +%Y%m%d)
if [[ "$BASE_VERSION" == *"-SNAPSHOT" ]]; then
VERSION="${BASE_VERSION/-SNAPSHOT/-nightly.${DATE}}"
else
VERSION="${BASE_VERSION}-nightly.${DATE}"
fi
```
Alternatively, keep `projectVersion` as `x.y.z-SNAPSHOT` on the default branch and rely on `-PprojectVersion` overrides for release publishing.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



No description provided.