Skip to content

chore: prepare release 1.3.0 #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ruromero merged 1 commit into from
Apr 14, 2026
Merged

chore: prepare release 1.3.0 #251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
projectVersion=1.3.0-SNAPSHOT
projectVersion=1.3.0

@qodo-code-review qodo-code-review Bot Apr 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Nightly suffix no-op 🐞 Bug ≡ Correctness

Nightly publishing computes VERSION by replacing "-SNAPSHOT" in projectVersion, but projectVersion
is now "1.3.0" so the replacement is a no-op and nightly builds will publish as the plain release
version (no "-nightly.<date>" suffix). This breaks the workflow’s stated intent to generate
date-stamped nightly versions and can cause version collisions across nightly runs.
Agent Prompt 
## Issue description
Nightly version computation in `.github/workflows/publish-marketplace.yml` relies on replacing `-SNAPSHOT` in `projectVersion`. After this PR sets `projectVersion=1.3.0`, the replacement becomes a no-op, so nightly runs produce `VERSION=1.3.0` instead of `1.3.0-nightly.<date>`.

## Issue Context
The workflow explicitly comments that it wants versions like `1.1.0-nightly.20240901`, but the current bash substitution only works when the base version contains `-SNAPSHOT`.

## Fix Focus Areas
- .github/workflows/publish-marketplace.yml[72-111]

## Suggested change
Update the nightly version calculation to append a nightly suffix even when the base version is not a `-SNAPSHOT`, e.g.:

```bash
BASE_VERSION=$(grep 'projectVersion=' gradle.properties | cut -d'=' -f2)
DATE=$(date +%Y%m%d)
if [[ "$BASE_VERSION" == *"-SNAPSHOT" ]]; then
  VERSION="${BASE_VERSION/-SNAPSHOT/-nightly.${DATE}}"
else
  VERSION="${BASE_VERSION}-nightly.${DATE}"
fi
```

Alternatively, keep `projectVersion` as `x.y.z-SNAPSHOT` on the default branch and rely on `-PprojectVersion` overrides for release publishing.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

jetBrainsToken=invalid
jetBrainsChannel=stable

Expand All @@ -20,4 +20,4 @@ kotlin.stdlib.default.dependency=false
org.gradle.configuration-cache=false

# Enable Gradle Build Cache -> https://docs.gradle.org/current/userguide/build_cache.html
org.gradle.caching=true
org.gradle.caching=true
Loading