chore: prepare next development version#252
Merged
Merged
Conversation
Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>
Review Summary by QodoPrepare next development version 1.4.0-SNAPSHOT
WalkthroughsDescription• Update project version to 1.4.0-SNAPSHOT • Prepare repository for next development cycle Diagramflowchart LR
A["projectVersion: 1.3.0"] -- "bump to next dev" --> B["projectVersion: 1.4.0-SNAPSHOT"]
File Changes1. gradle.properties
|
Code Review by Qodo
|
| @@ -1,4 +1,4 @@ | |||
| projectVersion=1.3.0 | |||
| projectVersion=1.4.0-SNAPSHOT | |||
There was a problem hiding this comment.
1. Release zip version mismatch 🐞 Bug ☼ Reliability
With projectVersion now set to 1.4.0-SNAPSHOT, the tag-driven release workflow runs buildPlugin without passing -PprojectVersion from the tag, so the built plugin version may not match the tag. This can cause the workflow to fail when uploading the expected tag-named ZIP from build/distributions.
Agent Prompt
### Issue description
The release workflow builds the plugin without forcing `projectVersion` to match the git tag, but later uploads an asset whose path/name is derived from the tag.
### Issue Context
`build.gradle.kts` sets `version` from the `projectVersion` Gradle property (from `gradle.properties` unless overridden). After this PR, that value is `*-SNAPSHOT`, which can diverge from the release tag.
### Fix Focus Areas
- /.github/workflows/release.yml[19-24]
- /build.gradle.kts[12-14]
### Suggested change
In `release.yml`, pass `-PprojectVersion=${{ steps.get_version.outputs.VERSION }}` to the `./gradlew buildPlugin` invocation (so the produced plugin/artifact version matches the tag used for the release asset name/path).
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



No description provided.