Skip to content

chore: prepare next development version#252

Merged
ruromero merged 1 commit into
redhat-developer:mainfrom
ruromero:next-dev
Apr 14, 2026
Merged

chore: prepare next development version#252
ruromero merged 1 commit into
redhat-developer:mainfrom
ruromero:next-dev

Conversation

@ruromero

Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>
@ruromero
ruromero merged commit 172dcf3 into redhat-developer:main Apr 14, 2026
5 checks passed
@ruromero
ruromero deleted the next-dev branch April 14, 2026 15:29
@qodo-code-review

Copy link
Copy Markdown

Review Summary by Qodo

Prepare next development version 1.4.0-SNAPSHOT

📦 Other

Grey Divider

Walkthroughs

Description
• Update project version to 1.4.0-SNAPSHOT
• Prepare repository for next development cycle
Diagram
flowchart LR
  A["projectVersion: 1.3.0"] -- "bump to next dev" --> B["projectVersion: 1.4.0-SNAPSHOT"]
Loading

Grey Divider

File Changes

1. gradle.properties ⚙️ Configuration changes +1/-1

Bump version to 1.4.0-SNAPSHOT

• Update projectVersion from 1.3.0 to 1.4.0-SNAPSHOT
• Mark repository as development version for next release cycle

gradle.properties


Grey Divider

Qodo Logo

@qodo-code-review

qodo-code-review Bot commented Apr 14, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1)   📘 Rule violations (0)   📎 Requirement gaps (0)
🐞\ ☼ Reliability (1)

Grey Divider


Action required

1. Release ZIP version mismatch 🐞
Description
With projectVersion now set to 1.4.0-SNAPSHOT, the tag-driven release workflow runs buildPlugin
without passing -PprojectVersion from the tag, so the built plugin version may not match the tag.
This can cause the workflow to fail when uploading the expected tag-named ZIP from
build/distributions.
Code

gradle.properties[1]

+projectVersion=1.4.0-SNAPSHOT
Evidence
The Gradle project version is sourced directly from gradle.properties projectVersion, which this PR
changes to a -SNAPSHOT value. The release workflow derives VERSION from the git tag and uses that
tag-derived VERSION in the asset_path it tries to upload, but it does not override projectVersion
when running buildPlugin, so the artifact produced can be versioned differently than the
tag/asset_path expectation.

/gradle.properties[1-3]
/build.gradle.kts[12-14]
/.github/workflows/release.yml[19-24]
/.github/workflows/release.yml[45-52]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
The release workflow builds the plugin without forcing `projectVersion` to match the git tag, but later uploads an asset whose path/name is derived from the tag.

### Issue Context
`build.gradle.kts` sets `version` from the `projectVersion` Gradle property (from `gradle.properties` unless overridden). After this PR, that value is `*-SNAPSHOT`, which can diverge from the release tag.

### Fix Focus Areas
- /.github/workflows/release.yml[19-24]
- /build.gradle.kts[12-14]

### Suggested change
In `release.yml`, pass `-PprojectVersion=${{ steps.get_version.outputs.VERSION }}` to the `./gradlew buildPlugin` invocation (so the produced plugin/artifact version matches the tag used for the release asset name/path).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

Comment thread gradle.properties
@@ -1,4 +1,4 @@
projectVersion=1.3.0
projectVersion=1.4.0-SNAPSHOT

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Release zip version mismatch 🐞 Bug ☼ Reliability

With projectVersion now set to 1.4.0-SNAPSHOT, the tag-driven release workflow runs buildPlugin
without passing -PprojectVersion from the tag, so the built plugin version may not match the tag.
This can cause the workflow to fail when uploading the expected tag-named ZIP from
build/distributions.
Agent Prompt
### Issue description
The release workflow builds the plugin without forcing `projectVersion` to match the git tag, but later uploads an asset whose path/name is derived from the tag.

### Issue Context
`build.gradle.kts` sets `version` from the `projectVersion` Gradle property (from `gradle.properties` unless overridden). After this PR, that value is `*-SNAPSHOT`, which can diverge from the release tag.

### Fix Focus Areas
- /.github/workflows/release.yml[19-24]
- /build.gradle.kts[12-14]

### Suggested change
In `release.yml`, pass `-PprojectVersion=${{ steps.get_version.outputs.VERSION }}` to the `./gradlew buildPlugin` invocation (so the produced plugin/artifact version matches the tag used for the release asset name/path).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant