fix(maven): replace internal MavenGeneralSettings.getLocalRepository() API#255
Merged
Conversation
…) API Use MavenProjectsManager.getRepositoryPath() which is public in both IntelliJ 2025.1 and 2025.2, instead of the internal getLocalRepository() method that was marked @ApiStatus.Internal in IC-252. Implements TC-4168 Assisted-by: Claude Code
Review Summary by QodoReplace internal Maven API with public alternative
WalkthroughsDescription• Replace internal MavenGeneralSettings.getLocalRepository() with public MavenProjectsManager.getRepositoryPath() API • Extract project resolution logic into reusable getProject() helper method • Ensure compatibility with IntelliJ 2025.1 and 2025.2 public APIs Diagramflowchart LR
A["MavenSettingsUtil.getLocalRepository()"] -->|"old: internal API"| B["MavenGeneralSettings.getLocalRepository()"]
A -->|"new: public API"| C["MavenProjectsManager.getRepositoryPath()"]
D["getProject() helper"] -->|"used by"| A
D -->|"used by"| E["getMavenGeneralSettings()"]
File Changes1. src/main/java/org/jboss/tools/intellij/settings/MavenSettingsUtil.java
|
Code Review by Qodo
1. Mixed project Maven settings
|
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
45
to
+46
| public static String getLocalRepository() { | ||
| MavenGeneralSettings settings = getMavenGeneralSettings(); | ||
| return settings.getLocalRepository(); | ||
| return MavenProjectsManager.getInstance(getProject()).getRepositoryPath().toString(); |
There was a problem hiding this comment.
1. Mixed project maven settings 🐞 Bug ≡ Correctness
MavenSettingsUtil.getLocalRepository() now resolves the repo path from MavenProjectsManager.getInstance(getProject()) on every call, while getUserSettingsFile()/isMavenWrapperSelected() use a static cached MavenGeneralSettings captured once. If the set/order of open projects changes (or multiple projects are open), ApiService can export Maven user settings from one project and the local repository from another, producing incorrect Maven environment properties for analysis.
Agent Prompt
### Issue description
`MavenSettingsUtil.getLocalRepository()` now derives the repository path from `MavenProjectsManager.getInstance(getProject())` each call, while other Maven settings (`getUserSettingsFile()`, `isMavenWrapperSelected()`) are derived from a statically cached `MavenGeneralSettings` captured once. This can mix settings across different open projects.
### Issue Context
`ApiService#setRequestProperties` sets multiple Maven-related system properties in one call path. These values must be resolved from the same `Project` instance to avoid exporting an inconsistent Maven configuration.
### Fix Focus Areas
- Align all Maven settings methods to use the same `Project` instance (preferably passed in from the caller rather than using `openProjects[0]`).
- Remove/avoid static cross-project caching of `MavenGeneralSettings`, or cache per-project if caching is required.
- src/main/java/org/jboss/tools/intellij/settings/MavenSettingsUtil.java[13-47]
- src/main/java/org/jboss/tools/intellij/exhort/ApiService.java[153-165]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MavenGeneralSettings.getLocalRepository()(internal API in IC-252) withMavenProjectsManager.getInstance(project).getRepositoryPath()(public in both 2025.1 and 2025.2)getProject()helper inMavenSettingsUtilgetUserSettingsFile(),getMavenHomeType(), orMavenWrapper— all confirmed publicImplements TC-4168
Test plan
./gradlew compileJavapasses./gradlew verifyPlugin—MavenGeneralSettings.getLocalRepository()no longer flagged./gradlew test— all existing tests pass🤖 Generated with Claude Code