fix(image): remove UBI branding and deprecated source-level recommendations (TC-4972)#264
Open
a-oren wants to merge 1 commit into
Open
fix(image): remove UBI branding and deprecated source-level recommendations (TC-4972)#264a-oren wants to merge 1 commit into
a-oren wants to merge 1 commit into
Conversation
…ations (TC-4972) Delete UBIIntentionAction and its hardcoded catalog.redhat.com link. Remove the deprecated source-level recommendation path (getRecommendation, findMatchingRecommendation) from DockerfileAnnotator since the backend no longer populates it for image analysis. Unify recommendation text to generic "Recommended image:" wording aligned with the VS Code extension. Update HardenedImageIntentionAction text to "Switch to X for enhanced security". Remove Ecosystem Catalog references from plugin.xml and README.md. Implements TC-4972 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Assisted-by: Claude Code
|
Collaborator
Author
Verification Report for TC-4972 (commit ae04123)
Overall: PASSAll checks pass. Test changes are reductive but justified — removed tests covered code paths that no longer exist (deleted This comment was AI-generated by sdlc-workflow/verify-pr v0.13.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UBIIntentionActionand its hardcodedcatalog.redhat.comlinkgetRecommendation,findMatchingRecommendation) fromDockerfileAnnotator— the backend no longer populates it for image analysis since the UBI provider was removedHardenedImageIntentionActiontext to "Switch to X for enhanced security"plugin.xmlandREADME.mdImplements TC-4972
Test plan
./gradlew buildpasses (compilation + all tests)getHardenedRecommendations()still works for provider-level recommendations