fix: use isExistingFormatterOverrideable to know which language server

must be used to format.

Signed-off-by: azerr <azerr@redhat.com>

Author: angelozerr

src/main/java/com/redhat/devtools/lsp4ij/client/features/LSPFormattingFeature.java

@@ -71,7 +71,7 @@ public boolean isSupported(@NotNull PsiFile file) {
      * @return true to use the language server for code formatting and false to use plugin-provided/built-in formatters.
      * @apiNote This method will only be called with files that contain a language supported by this language server.
      */
-    protected boolean isExistingFormatterOverrideable(@NotNull PsiFile file) {
+    public boolean isExistingFormatterOverrideable(@NotNull PsiFile file) {
         return false;
     }
 

src/main/java/com/redhat/devtools/lsp4ij/features/formatting/LSPFormattingSupport.java

@@ -141,16 +141,20 @@ protected CompletableFuture<List<? extends TextEdit>> doLoad(LSPFormattingParams
         boolean isRangeFormatting = textRange != null;
         Ref<LanguageServerItem> server = Ref.create(null);
         LanguageServiceAccessor.getInstance(file.getProject()).processLanguageServers(file, ls -> {
-            if (!isRangeFormatting) {
-                if (server.isNull() && ls.getClientFeatures().getFormattingFeature().isFormattingSupported(file)) {
-                    server.set(new LanguageServerItem(ls.getLanguageServer(), ls));
-                }
-            } else {
-                if  (ls.getClientFeatures().getFormattingFeature().isFormattingSupported(file) ||
-                        ls.getClientFeatures().getFormattingFeature().isRangeFormattingSupported(file)) {
-                    if (server.isNull() || !server.get().isDocumentRangeFormattingSupported()) {
+            var formattingFeature = ls.getClientFeatures().getFormattingFeature();
+            if (formattingFeature.isEnabled(file)) {
+                boolean overridable = formattingFeature.isExistingFormatterOverrideable(file);
+                if (!isRangeFormatting) {
+                    if ((overridable || server.isNull()) && formattingFeature.isFormattingSupported(file)) {
                         server.set(new LanguageServerItem(ls.getLanguageServer(), ls));
                     }
+                } else {
+                    if (formattingFeature.isFormattingSupported(file) ||
+                            formattingFeature.isRangeFormattingSupported(file)) {
+                        if (overridable || server.isNull() || !server.get().isDocumentRangeFormattingSupported()) {
+                            server.set(new LanguageServerItem(ls.getLanguageServer(), ls));
+                        }
+                    }
                 }
             }
         });

src/main/java/com/redhat/devtools/lsp4ij/server/definition/launching/ClientConfigurationSettings.java

@@ -171,6 +171,8 @@ public static class OnTypeFormattingSettings {
      */
     public static class ClientConfigurationFormatSettings {
 
+        public @Nullable Boolean enabled;
+
         public @Nullable Integer tabSize;
 
         public @Nullable Boolean insertSpaces;

src/main/java/com/redhat/devtools/lsp4ij/server/definition/launching/UserDefinedFormattingFeature.java

@@ -35,6 +35,12 @@ private ClientConfigurationSettings.ClientConfigurationFormatSettings getClientC
         return clientConfiguration != null ? clientConfiguration.format : null;
     }
 
+    @Override
+    public boolean isEnabled(@NotNull PsiFile file) {
+        var format = getClientConfigurationFormatSettings();
+        return format != null && format.enabled != null ? format.enabled : super.isEnabled(file);
+    }
+
     @Override
     public @Nullable Integer getTabSize(@NotNull PsiFile file, @Nullable Editor editor) {
         var format = getClientConfigurationFormatSettings();
@@ -48,7 +54,7 @@ private ClientConfigurationSettings.ClientConfigurationFormatSettings getClientC
     }
 
     @Override
-    protected boolean isExistingFormatterOverrideable(@NotNull PsiFile file) {
+    public boolean isExistingFormatterOverrideable(@NotNull PsiFile file) {
         var format = getClientConfigurationFormatSettings();
         return format != null && format.existingFormatterOverrideable != null ? format.existingFormatterOverrideable : super.isExistingFormatterOverrideable(file);
     }

src/main/resources/jsonSchema/clientSettings.schema.json

@@ -122,6 +122,11 @@
       "title": "Client-side formatter configuration",
       "additionalProperties": false,
       "properties": {
+        "enabled": {
+          "type": "boolean",
+          "title": "Server-side formatting enabled",
+          "description": "Server-side formatting enabled"
+        },
         "tabSize": {
           "type": "integer",
           "title": "Size of a tab in spaces.",
@@ -135,7 +140,7 @@
         "existingFormatterOverrideable": {
           "type": "boolean",
           "title": "Returns true to use the language server for code formatting and false to use plugin-provided/built-in formatters.",
-          "description": "Prefer spaces over tabs."
+          "description": "Returns true to use the language server for code formatting and false to use plugin-provided/built-in formatters."
         },
         "onTypeFormatting": {
           "type": "object",