Renaming implementation on client differs from VS Code

[sergeysavchuk]

Use case:
When renaming a symbol, a set of files should be renamed.

Flow:

• Client sends textDocument/rename request to LS.
• LS responds with WorkspaceEdit containing RenameFile ResourceOperation.
• Client applies the operation in com.redhat.devtools.lsp4ij.LSPIJUtils#applyWorkspaceEdit(org.eclipse.lsp4j.WorkspaceEdit, java.lang.String)

Actual result:
Client doesn’t send workspace/didRenameFiles notification for files from RenameFile operation.

Expected result:
As in VS Code, the client should send workspace/didRenameFiles notification for files from RenameFile operation.

[angelozerr]

Indeed LSPIJUtils#applyWorkspaceEdit should be improved to manage this notification and also for create and delete by taking care of that server has the capability to send the notification.

[angelozerr]

@sergeysavchuk could you review please #1321

[sergeysavchuk]

@angelozerr tu, let me time to test it

[angelozerr]

@sergeysavchuk I have restarted very quickly a new PR #1321 where I did some refactoring which could impact didChangedWatchFiles.

You can start to play with it, but I am not sure that it will not provide some bugs.

[angelozerr]

@sergeysavchuk dont test it doesnt work. I will ping you when my PR will be more tested