Skip to content

fix: replace Internal PluginManagerCore.getPlugin (since 2026.2 eap) with Manager.getInstance().findEnabledPlugin #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angelozerr merged 1 commit into from
May 14, 2026
Merged

fix: replace Internal PluginManagerCore.getPlugin (since 2026.2 eap) with Manager.getInstance().findEnabledPlugin #1498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/com/redhat/devtools/lsp4ij/dap/descriptors/DebugAdapterDescriptorFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
import com.intellij.execution.configurations.RunConfigurationOptions;
import com.intellij.execution.runners.ExecutionEnvironment;
import com.intellij.ide.plugins.IdeaPluginDescriptor;
import com.intellij.ide.plugins.PluginManagerCore;
import com.intellij.ide.plugins.PluginManager;
import com.intellij.openapi.extensions.PluginId;
import com.intellij.openapi.options.SettingsEditor;
import com.intellij.openapi.project.Project;
Expand Down Expand Up @@ -159,7 +159,7 @@ public final void setServerDefinition(DebugAdapterServerDefinition serverDefinit

public static Path getDebugAdapterServerPath(@NotNull String pluginId,
@NotNull String serverPath) {
IdeaPluginDescriptor descriptor = PluginManagerCore.getPlugin(PluginId.getId(pluginId));
IdeaPluginDescriptor descriptor = PluginManager.getInstance().findEnabledPlugin(PluginId.getId(pluginId));
assert descriptor != null;
Path pluginPath = descriptor.getPluginPath();
assert pluginPath != null;
Expand Down
4 changes: 2 additions & 2 deletions ...in/java/com/redhat/devtools/lsp4ij/dap/disassembly/DisassemblyTextMateBundleProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
package com.redhat.devtools.lsp4ij.dap.disassembly;

import com.intellij.ide.plugins.IdeaPluginDescriptor;
import com.intellij.ide.plugins.PluginManagerCore;
import com.intellij.ide.plugins.PluginManager;
import com.intellij.openapi.extensions.PluginId;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.plugins.textmate.api.TextMateBundleProvider;
Expand Down Expand Up @@ -48,7 +48,7 @@ public List<PluginBundle> getBundles() {

private Path getBundlePath() {
try {
IdeaPluginDescriptor plugin = PluginManagerCore.getPlugin(PluginId.getId("com.redhat.devtools.lsp4ij"));
IdeaPluginDescriptor plugin = PluginManager.getInstance().findEnabledPlugin(PluginId.getId("com.redhat.devtools.lsp4ij"));
String version = plugin.getVersion();
String path = plugin.getPluginPath() + "/bundles/" + version;
return copyResourceDirectory(path, List.of("package.json", "syntaxes/disassembly.json"));
Expand Down
4 changes: 2 additions & 2 deletions ...m/redhat/devtools/lsp4ij/dap/runInTerminal/integrated/RunInIntegratedTerminalService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
******************************************************************************/
package com.redhat.devtools.lsp4ij.dap.runInTerminal.integrated;

import com.intellij.ide.plugins.PluginManagerCore;
import com.intellij.ide.plugins.PluginManager;
import com.intellij.openapi.application.ApplicationManager;
import com.intellij.openapi.extensions.PluginId;
import com.intellij.openapi.util.SystemInfo;
Expand Down Expand Up @@ -129,7 +129,7 @@ public class RunInIntegratedTerminalService implements RunInTerminalService {
@Override
public boolean isApplicable() {
PluginId pluginId = PluginId.getId("org.jetbrains.plugins.terminal");
return PluginManagerCore.getPlugin(pluginId) != null;
return PluginManager.getInstance().findEnabledPlugin(pluginId) != null;
}

/**
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/com/redhat/devtools/lsp4ij/launching/templates/LanguageServerTemplate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
******************************************************************************/
package com.redhat.devtools.lsp4ij.launching.templates;

import com.intellij.ide.plugins.PluginManagerCore;
import com.intellij.ide.plugins.PluginManager;
import com.intellij.openapi.extensions.PluginId;
import com.redhat.devtools.lsp4ij.LanguageServerBundle;
import com.redhat.devtools.lsp4ij.templates.ServerTemplate;
Expand Down Expand Up @@ -158,6 +158,6 @@ private boolean computePromotable() {

private static boolean isPluginInstalled(String pluginIdString) {
PluginId pluginId = PluginId.getId(pluginIdString);
return PluginManagerCore.getPlugin(pluginId) != null;
return PluginManager.getInstance().findEnabledPlugin(pluginId) != null;
}
}
Loading